Skip to content

Commit 9f1fa91

Browse files
neildharfacebook-github-bot
authored andcommitted
Fix Windows build in CI (#33566)
Summary: Pull Request resolved: #33566 Changelog: [Internal] Reviewed By: cortinico Differential Revision: D35379924 fbshipit-source-id: 90f776afa095d99a6a6d2c7d002fb1f731ff34ef
1 parent c7380ba commit 9f1fa91

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1021,7 +1021,7 @@ jobs:
10211021
$Env:PATH += ";$Env:CMAKE_DIR;$Env:MSBUILD_DIR"
10221022
$Env:ICU_ROOT = "$Env:HERMES_WS_DIR\icu"
10231023
cd $Env:HERMES_WS_DIR
1024-
cmake -S hermes -B build_release -G 'Visual Studio 16 2019' -DCMAKE_BUILD_TYPE=Release -DHERMES_ENABLE_WIN10_ICU_FALLBACK=OFF -DHERMES_GITHUB_RESOURCE_DIR=$Env:HERMES_WS_DIR\deps
1024+
cmake -S hermes -B build_release -G 'Visual Studio 16 2019' -DCMAKE_BUILD_TYPE=Release -DHERMES_ENABLE_WIN10_ICU_FALLBACK=OFF -DHERMES_GITHUB_RESOURCE_DIR="$Env:HERMES_WS_DIR\deps"
10251025
if (-not $?) { throw "Failed to configure Hermes" }
10261026
cd build_release
10271027
cmake --build . --target github-cli-release --config Release

0 commit comments

Comments
 (0)