Remove deprecated uses of UIActivityIndicatorViewStyle (#38208)

Saadnajmi · facebook-github-bot · commit 62e9faefd5f1 · 2023-07-06T03:19:58.000-07:00
Summary: Super simple change to replace some deprecated ENUM values with the correct one, now that we're on iOS 13.0+. From `UIActivityIndicator.h`: ``` typedef NS_ENUM(NSInteger, UIActivityIndicatorViewStyle) { UIActivityIndicatorViewStyleMedium API_AVAILABLE(ios(13.0), tvos(13.0)) = 100, UIActivityIndicatorViewStyleLarge API_AVAILABLE(ios(13.0), tvos(13.0)) = 101, UIActivityIndicatorViewStyleWhiteLarge API_DEPRECATED_WITH_REPLACEMENT("UIActivityIndicatorViewStyleLarge", ios(2.0, 13.0), tvos(9.0, 13.0)) = 0, UIActivityIndicatorViewStyleWhite API_DEPRECATED_WITH_REPLACEMENT("UIActivityIndicatorViewStyleMedium", ios(2.0, 13.0), tvos(9.0, 13.0)) = 1, UIActivityIndicatorViewStyleGray API_DEPRECATED_WITH_REPLACEMENT("UIActivityIndicatorViewStyleMedium", ios(2.0, 13.0)) API_UNAVAILABLE(tvos) = 2, }; ``` ## Changelog: [IOS] [CHANGED] - Remove deprecated uses of UIActivityIndicatorViewStyle Pull Request resolved: #38208 Test Plan: CI should pass Reviewed By: cipolleschi Differential Revision: D47254035 Pulled By: rshest fbshipit-source-id: 6d3270899e8d52611d91c777f324c3c6f0c520be
diff --git a/packages/react-native/React/Fabric/Mounting/ComponentViews/ActivityIndicator/RCTActivityIndicatorViewComponentView.mm b/packages/react-native/React/Fabric/Mounting/ComponentViews/ActivityIndicator/RCTActivityIndicatorViewComponentView.mm
@@ -21,9 +21,9 @@ static UIActivityIndicatorViewStyle convertActivityIndicatorViewStyle(const Acti
 {
   switch (size) {
     case ActivityIndicatorViewSize::Small:
-      return UIActivityIndicatorViewStyleWhite;
+      return UIActivityIndicatorViewStyleMedium;
     case ActivityIndicatorViewSize::Large:
-      return UIActivityIndicatorViewStyleWhiteLarge;
+      return UIActivityIndicatorViewStyleLarge;
   }
 }
 
diff --git a/packages/react-native/React/Views/RCTActivityIndicatorViewManager.m b/packages/react-native/React/Views/RCTActivityIndicatorViewManager.m
@@ -18,10 +18,10 @@ @implementation RCTConvert (UIActivityIndicatorView)
 RCT_ENUM_CONVERTER(
     UIActivityIndicatorViewStyle,
     (@{
-      @"large" : @(UIActivityIndicatorViewStyleWhiteLarge),
-      @"small" : @(UIActivityIndicatorViewStyleWhite),
+      @"large" : @(UIActivityIndicatorViewStyleLarge),
+      @"small" : @(UIActivityIndicatorViewStyleMedium),
     }),
-    UIActivityIndicatorViewStyleWhiteLarge,
+    UIActivityIndicatorViewStyleLarge,
     integerValue)
 
 @end

Original file line number	Diff line number	Diff line change
`@@ -21,9 +21,9 @@ static UIActivityIndicatorViewStyle convertActivityIndicatorViewStyle(const Acti`
`21`	`21`	`{`
`22`	`22`	`switch (size) {`
`23`	`23`	`case ActivityIndicatorViewSize::Small:`
`24`		`- return UIActivityIndicatorViewStyleWhite;`
	`24`	`+ return UIActivityIndicatorViewStyleMedium;`
`25`	`25`	`case ActivityIndicatorViewSize::Large:`
`26`		`- return UIActivityIndicatorViewStyleWhiteLarge;`
	`26`	`+ return UIActivityIndicatorViewStyleLarge;`
`27`	`27`	`}`
`28`	`28`	`}`
`29`	`29`