Fix reorder-init-list warning in RCTViewComponentView

motiz88 · facebook-github-bot · commit 345baf477cd7 · 2020-09-01T07:32:57.000-07:00
Summary:
Changes the order of `RCTBorderColors` field designators to match their declaration order, fixing one case of `-Wreorder-init-list` when compiling the RN codebase with Xcode 12.

Changelog: [Internal]

Reviewed By: MichaReiser

Differential Revision: D23447685

fbshipit-source-id: f04a3841187f0869d2efb60e81ce075c45f27f3c
diff --git a/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm b/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
@@ -340,8 +340,8 @@ static RCTCornerRadii RCTCornerRadiiFromBorderRadii(BorderRadii borderRadii)
 
 static RCTBorderColors RCTBorderColorsFromBorderColors(BorderColors borderColors)
 {
-  return RCTBorderColors{.left = RCTCGColorRefUnretainedFromSharedColor(borderColors.left),
-                         .top = RCTCGColorRefUnretainedFromSharedColor(borderColors.top),
+  return RCTBorderColors{.top = RCTCGColorRefUnretainedFromSharedColor(borderColors.top),
+                         .left = RCTCGColorRefUnretainedFromSharedColor(borderColors.left),
                          .bottom = RCTCGColorRefUnretainedFromSharedColor(borderColors.bottom),
                          .right = RCTCGColorRefUnretainedFromSharedColor(borderColors.right)};
 }

Original file line number	Diff line number	Diff line change
`@@ -340,8 +340,8 @@ static RCTCornerRadii RCTCornerRadiiFromBorderRadii(BorderRadii borderRadii)`
`340`	`340`
`341`	`341`	`static RCTBorderColors RCTBorderColorsFromBorderColors(BorderColors borderColors)`
`342`	`342`	`{`
`343`		`- return RCTBorderColors{.left = RCTCGColorRefUnretainedFromSharedColor(borderColors.left),`
`344`		`- .top = RCTCGColorRefUnretainedFromSharedColor(borderColors.top),`
	`343`	`+ return RCTBorderColors{.top = RCTCGColorRefUnretainedFromSharedColor(borderColors.top),`
	`344`	`+ .left = RCTCGColorRefUnretainedFromSharedColor(borderColors.left),`
`345`	`345`	`.bottom = RCTCGColorRefUnretainedFromSharedColor(borderColors.bottom),`
`346`	`346`	`.right = RCTCGColorRefUnretainedFromSharedColor(borderColors.right)};`
`347`	`347`	`}`