Skip to content

Commit 243a148

Browse files
cortinicofacebook-github-bot
cortinico
authored and
facebook-github-bot
committed
Remove unnecessary files in RN-Tester (#37152)
Summary: Pull Request resolved: #37152 Those files are unncessary and can be removed from RNTester. * Proguard file is empty * Signing config is unnecessary and we can use the debug one also for release. Changelog: [Internal] [Changed] - Remove unnecessary files in RN-Tester Reviewed By: hoxyq Differential Revision: D45399388 fbshipit-source-id: fd1c6cccaef668e688a699e31045bdc8103ea98e
1 parent b33cc7d commit 243a148

File tree

4 files changed

+2
-35
lines changed

4 files changed

+2
-35
lines changed

‎packages/rn-tester/android/app/build.gradle‎

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -123,14 +123,6 @@ android {
123123
testBuildType System.getProperty('testBuildType', 'debug') // This will later be used to control the test apk build type
124124
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
125125
}
126-
signingConfigs {
127-
release {
128-
storeFile file(MYAPP_RELEASE_STORE_FILE)
129-
storePassword MYAPP_RELEASE_STORE_PASSWORD
130-
keyAlias MYAPP_RELEASE_KEY_ALIAS
131-
keyPassword MYAPP_RELEASE_KEY_PASSWORD
132-
}
133-
}
134126
externalNativeBuild {
135127
cmake {
136128
version cmakeVersion
@@ -145,15 +137,10 @@ android {
145137
}
146138
}
147139
buildTypes {
148-
debug {
149-
debuggable true
150-
signingConfig signingConfigs.release
151-
}
152140
release {
153-
debuggable false
154141
minifyEnabled enableProguardInReleaseBuilds
155-
proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
156-
signingConfig signingConfigs.release
142+
proguardFiles getDefaultProguardFile('proguard-android.txt')
143+
signingConfig signingConfigs.debug
157144
}
158145
}
159146
sourceSets.main {

‎packages/rn-tester/android/app/gradle.properties‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
org.gradle.parallel=true
22
# This is causing issue with dependencies task: https://github.com/gradle/gradle/issues/9645#issuecomment-530746758
33
# org.gradle.configureondemand=true
4-
MYAPP_RELEASE_STORE_FILE=my-release-key.keystore
5-
MYAPP_RELEASE_KEY_ALIAS=androiddebugkey
6-
MYAPP_RELEASE_STORE_PASSWORD=android
7-
MYAPP_RELEASE_KEY_PASSWORD=android
8-
94
android.useAndroidX=true
105
android.enableJetifier=true
116

‎packages/rn-tester/android/app/my-release-key.keystore‎

-2.2 KB
Binary file not shown.

‎packages/rn-tester/android/app/proguard-rules.pro‎

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)