Skip to content

Clear transition timeouts when component unmounts. Fixes #4876 #5391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimfb merged 1 commit into from
Nov 5, 2015
+27 −0
Merged

Clear transition timeouts when component unmounts. Fixes #4876 #5391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/addons/transitions/ReactCSSTransitionGroupChild.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ var ReactCSSTransitionGroupChild = React.createClass({
if (userSpecifiedDelay) {
// Clean-up the animation after the specified delay
timeout = setTimeout(endListener, userSpecifiedDelay);
this.transitionTimeouts.push(timeout);
} else {
// DEPRECATED: this listener will be removed in a future version of react
ReactTransitionEvents.addEndEventListener(node, endListener);
Expand All @@ -126,12 +127,16 @@ var ReactCSSTransitionGroupChild = React.createClass({

componentWillMount: function() {
this.classNameQueue = [];
this.transitionTimeouts = [];
},

componentWillUnmount: function() {
if (this.timeout) {
clearTimeout(this.timeout);
}
this.transitionTimeouts.forEach(function(timeout) {
clearTimeout(timeout);
});
},

componentWillAppear: function(done) {
Expand Down
22 changes: 22 additions & 0 deletions src/addons/transitions/__tests__/ReactCSSTransitionGroup-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,4 +269,26 @@ describe('ReactCSSTransitionGroup', function() {
var leavingNode = ReactDOM.findDOMNode(a).childNodes[0];
expect(CSSCore.hasClass(leavingNode, 'custom-leaving')).toBe(true);
});

it('should clear transition timeouts when unmounted', function() {
var Component = React.createClass({
render: function() {
return (
<ReactCSSTransitionGroup
transitionName="yolo"
transitionEnterTimeout={500}>
{this.props.children}
</ReactCSSTransitionGroup>
);
},
});

ReactDOM.render(<Component/>, container);
ReactDOM.render(<Component><span key="yolo" id="yolo"/></Component>, container);

ReactDOM.unmountComponentAtNode(container);

// Testing that no exception is thrown here, as the timeout has been cleared.
jest.runAllTimers();
});
});