Skip to content

Fix runtime_commit_artifacts workflow #31028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
poteto merged 7 commits into from
Sep 23, 2024
Merged

Fix runtime_commit_artifacts workflow #31028

poteto merged 7 commits into from
Sep 23, 2024

Conversation

@poteto
Copy link
Member

@poteto poteto commented Sep 23, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

I messed up the yml syntax and also realized that our script doesn't
currently handle renames or deletes, so I fixed that

@poteto
Update
45ba632 
[ghstack-poisoned]
@vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 9:35pm

poteto added a commit that referenced this pull request Sep 23, 2024
@poteto
Fix yml
b866ce2 
ghstack-source-id: cb91cb8
Pull Request resolved: #31028
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 23, 2024
@react-sizebot
Copy link

react-sizebot commented Sep 23, 2024 •
edited
Loading

Comparing: 5b19dc0f06e92d3ed0aa93be3c5bbe2298da5df6...4963983a8806e0c5c27ff0bc091469eb389ceb96

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.11% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 509.10 kB 509.10 kB = 91.06 kB 91.06 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 514.04 kB 514.04 kB = 91.78 kB 91.78 kB
facebook-www/ReactDOM-prod.classic.js = 603.53 kB 603.53 kB = 106.78 kB 106.78 kB
facebook-www/ReactDOM-prod.modern.js = 579.76 kB 579.76 kB = 102.88 kB 102.88 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 2e1d261

@poteto
Update
add21be 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 23, 2024
@poteto
Fix yml
c5a57cd 
ghstack-source-id: b426687
Pull Request resolved: #31028
@poteto
Update
5ecdc2b 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 23, 2024
@poteto
Fix yml
82e6344 
ghstack-source-id: e5cc566
Pull Request resolved: #31028
@poteto
Update
e8827c2 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 23, 2024
@poteto
Fix yml
8a49e6a 
ghstack-source-id: 2d17fe2
Pull Request resolved: #31028
@poteto
Update
d89724b 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 23, 2024
@poteto
Fix yml
87480fc 
ghstack-source-id: 90d6454
Pull Request resolved: #31028
poteto added a commit that referenced this pull request Sep 23, 2024
@poteto
Fix yml
5970c5d 
ghstack-source-id: 90d6454
Pull Request resolved: #31028
@poteto
Update
7f8b60e 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 23, 2024
@poteto
Fix yml
740ad40 
ghstack-source-id: 83bd7ea
Pull Request resolved: #31028
@poteto
Update
2e1d261 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 23, 2024
@poteto
Fix yml
bb7c556 
ghstack-source-id: 7d481a9
Pull Request resolved: #31028
@poteto poteto changed the title Fix yml Fix runtime_commit_artifacts workflow Sep 23, 2024
poteto added a commit that referenced this pull request Sep 23, 2024
@poteto
Fix runtime_commit_artifacts workflow
2326ab8 
I messed up the yml syntax and also realized that our script doesn't
currently handle renames or deletes, so I fixed that

ghstack-source-id: 7d481a9
Pull Request resolved: #31028
poteto added a commit that referenced this pull request Sep 23, 2024
@poteto
Fix runtime_commit_artifacts workflow
5e6dc6f 
I messed up the yml syntax and also realized that our script doesn't
currently handle renames or deletes, so I fixed that

ghstack-source-id: 7d481a9
Pull Request resolved: #31028
@poteto poteto merged commit 2e1d261 into gh/poteto/6/base Sep 23, 2024
poteto added a commit that referenced this pull request Sep 23, 2024
@poteto
Fix runtime_commit_artifacts workflow
4708fb9 
I messed up the yml syntax and also realized that our script doesn't
currently handle renames or deletes, so I fixed that

ghstack-source-id: 7d481a9
Pull Request resolved: #31028
@poteto poteto deleted the gh/poteto/6/head branch September 23, 2024 21:39
This was referenced Sep 24, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackpope jackpope jackpope approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@poteto @react-sizebot @jackpope @facebook-github-bot