[Fizz] Pass task.childIndex in retryReplayTask #27594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed that we track the child index on the task. The equivalent in retryRenderTask already has this.
facebook-github-bot
added
the
React Core Team
sebmarkbage
force-pushed
the
fixchildindex
branch
from
e3e1f1a to
7ea07fa
Compare
acdlite
approved these changes
Oct 26, 2023
gnoff
approved these changes
Oct 26, 2023
|
Comparing: 97047a8...7ea07fa Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
acdlite
added a commit
to acdlite/next.js
that referenced
this pull request
Oct 26, 2023
React upstream changes: - facebook/react#27594 - facebook/react#27584
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Oct 26, 2023
React upstream changes: - facebook/react#27594 - facebook/react#27584 Co-authored-by: Jiachi Liu <[email protected]>
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
This was missed that we track the child index on the task. The equivalent in retryRenderTask already has this. The effect is that a lazy node that suspends gets its child index reset to -1 even though it should resume in the index it left off.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
This was missed that we track the child index on the task. The equivalent in retryRenderTask already has this. The effect is that a lazy node that suspends gets its child index reset to -1 even though it should resume in the index it left off. DiffTrain build for commit 8c8ee9e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed that we track the child index on the task. The equivalent in retryRenderTask already has this.
The effect is that a lazy node that suspends gets its child index reset to -1 even though it should resume in the index it left off.