Remove ad-hoc forks of getComponentName() and fix it #13197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't actually need the whole Fiber.
gaearon
commented
Jul 12, 2018
| ? type | ||
| : typeof type === 'function' ? type.displayName || type.name : null; | ||
| } | ||
|
|
| return type.displayName || type.name || 'Unknown'; | ||
| } | ||
| }; | ||
|
|
| false, | ||
| 'Received an unexpected object in getComponentName(). ' + | ||
| 'This is likely a bug in React. Please file an issue.', | ||
| ); |
Collaborator
Author
There was a problem hiding this comment.
Protect against passing Fibers by habit.
| return 'ReactPortal'; | ||
| return 'Portal'; | ||
| case REACT_PROFILER_TYPE: | ||
| return `Profiler(${fiber.pendingProps.id})`; |
Collaborator
Author
There was a problem hiding this comment.
If you feel strongly about keeping this, I can add an optional props argument. I'm not sure this is important. I like that having a type is sufficient (which lets us use this utility in SSR, for example).
Contributor
There was a problem hiding this comment.
I'm not sure what this is used for and I see no comments anywhere from before?
Contributor
There was a problem hiding this comment.
No, it's fine. I was just following the forward ref precedent. I think it's mildly useful, but not enough to warrant making the callsites more complicated.
Collaborator
Author
There was a problem hiding this comment.
It provided a slightly more detailed entry in the component stack for Profiler components. I don't think it's very important, and I think we can drop this.
|
ReactDOM: size: -0.0%, gzip: -0.0% Details of bundled changes.Comparing: 32f6f25...71590b7 react
react-dom
react-test-renderer
react-art
react-native-renderer
Generated by 🚫 dangerJS |
bvaughn
approved these changes
Jul 12, 2018
Contributor
bvaughn
left a comment
bvaughn
left a comment
There was a problem hiding this comment.
This is a nice cleanup! Thanks for removing those forks.
| return 'ReactPortal'; | ||
| return 'Portal'; | ||
| case REACT_PROFILER_TYPE: | ||
| return `Profiler(${fiber.pendingProps.id})`; |
Contributor
There was a problem hiding this comment.
No, it's fine. I was just following the forward ref precedent. I think it's mildly useful, but not enough to warrant making the callsites more complicated.
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
* Fix getComponentName() for types with nested $$typeof * Temporarily remove Profiler ID from messages * Change getComponentName() signature to take just type It doesn't actually need the whole Fiber. * Remove getComponentName() forks in isomorphic and SSR * Remove unnecessary .type access where we already have a type * Remove unused type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getComponentName()for a few cases where it was incorrectly reading the type (a482fb4). We didn't notice because we rarely call it for anything other than user-defined components.typealone rather than the Fiber. This might seem like it makes the calling code longer. However we often already have the type destructured anyway when we call it. I also remember from writing some of that code that it was awkward to always have to pass a Fiber around when I only needed a type.getComponentName()that don't handle all the cases it does.