Don't show tooltips when mouse is down on an active view/surface/tool

Brian Vaughn · Brian Vaughn · commit d70b5839af25 · 2021-07-27T14:24:20.000-04:00
diff --git a/packages/react-devtools-scheduling-profiler/src/CanvasPage.js b/packages/react-devtools-scheduling-profiler/src/CanvasPage.js
@@ -507,7 +507,7 @@ function AutoSizedCanvas({data, height, width}: AutoSizedCanvasProps) {
           );
         }}
       </ContextMenu>
-      {!isContextMenuShown && (
+      {!isContextMenuShown && !surfaceRef.current.hasActiveView() && (
         <EventTooltip
           data={data}
           hoveredEvent={hoveredEvent}
diff --git a/packages/react-devtools-scheduling-profiler/src/view-base/Surface.js b/packages/react-devtools-scheduling-profiler/src/view-base/Surface.js
@@ -62,6 +62,10 @@ export class Surface {
     hoveredView: null,
   };
 
+  hasActiveView(): boolean {
+    return this._viewRefs.activeView !== null;
+  }
+
   setCanvas(canvas: HTMLCanvasElement, canvasSize: Size) {
     this._context = getCanvasContext(
       canvas,
