fix: check bigint in serializeToString and change it to string

farhadyasir · farhadyasir · commit 9fc9f768fd5c · 2020-01-31T23:24:39.000+11:00
diff --git a/packages/react-devtools-shared/src/backend/legacy/renderer.js b/packages/react-devtools-shared/src/backend/legacy/renderer.js
@@ -14,12 +14,7 @@ import {
   ElementTypeHostComponent,
   ElementTypeOtherOrUnknown,
 } from 'react-devtools-shared/src/types';
-import {
-  getUID,
-  utfEncodeString,
-  printOperationsArray,
-  formatDataForPreview,
-} from '../../utils';
+import {getUID, utfEncodeString, printOperationsArray} from '../../utils';
 import {cleanForBridge, copyToClipboard, copyWithSet} from '../utils';
 import {getDisplayName, getInObject} from 'react-devtools-shared/src/utils';
 import {
@@ -679,9 +674,7 @@ export function attach(
   function copyElementPath(id: number, path: Array<string | number>): void {
     const inspectedElement = inspectElementRaw(id);
     if (inspectedElement !== null) {
-      copyToClipboard(
-        formatDataForPreview(getInObject(inspectedElement, path), true),
-      );
+      copyToClipboard(getInObject(inspectedElement, path));
     }
   }
 
diff --git a/packages/react-devtools-shared/src/backend/renderer.js b/packages/react-devtools-shared/src/backend/renderer.js
@@ -35,7 +35,6 @@ import {
 } from 'react-devtools-shared/src/utils';
 import {sessionStorageGetItem} from 'react-devtools-shared/src/storage';
 import {cleanForBridge, copyToClipboard, copyWithSet} from './utils';
-import {formatDataForPreview} from '../utils';
 import {
   __DEBUG__,
   SESSION_STORAGE_RELOAD_AND_PROFILE_KEY,
@@ -2532,12 +2531,9 @@ export function attach(
 
     if (isCurrent) {
       copyToClipboard(
-        formatDataForPreview(
-          getInObject(
-            ((mostRecentlyInspectedElement: any): InspectedElement),
-            path,
-          ),
-          true,
+        getInObject(
+          ((mostRecentlyInspectedElement: any): InspectedElement),
+          path,
         ),
       );
     }
diff --git a/packages/react-devtools-shared/src/backend/utils.js b/packages/react-devtools-shared/src/backend/utils.js
@@ -81,6 +81,10 @@ export function serializeToString(data: any): string {
       }
       cache.add(value);
     }
+    // $FlowFixMe
+    if (typeof value === 'bigint') {
+      return value.toString() + 'n';
+    }
     return value;
   });
 }
diff --git a/packages/react-devtools-shell/src/app/InspectableElements/UnserializableProps.js b/packages/react-devtools-shell/src/app/InspectableElements/UnserializableProps.js
@@ -31,8 +31,8 @@ const immutable = Immutable.fromJS({
     xyz: 1,
   },
 });
-// eslint-disable-next-line no-undef
-const bigInt = BigInt(123);
+// $FlowFixMe
+const bigInt = BigInt(123); // eslint-disable-line no-undef
 
 export default function UnserializableProps() {
   return (

Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,10 @@ export function serializeToString(data: any): string {`
`81`	`81`	`}`
`82`	`82`	`cache.add(value);`
`83`	`83`	`}`
	`84`	`+ // $FlowFixMe`
	`85`	`+ if (typeof value === 'bigint') {`
	`86`	`+ return value.toString() + 'n';`
	`87`	`+ }`
`84`	`88`	`return value;`
`85`	`89`	`});`
`86`	`90`	`}`