test(react-debug-tools): Improve coverage of currentDispatcher.current setter (#24945)

eps1lon · web-flow · commit 9bd0dd4c181a · 2022-07-21T15:46:43.000-04:00
diff --git a/packages/react-debug-tools/src/__tests__/ReactHooksInspection-test.js b/packages/react-debug-tools/src/__tests__/ReactHooksInspection-test.js
@@ -256,12 +256,11 @@ describe('ReactHooksInspection', () => {
   });
 
   it('should support an injected dispatcher', () => {
-    function Foo(props) {
-      const [state] = React.useState('hello world');
-      return <div>{state}</div>;
-    }
-
-    const initial = {};
+    const initial = {
+      useState() {
+        throw new Error("Should've been proxied");
+      },
+    };
     let current = initial;
     let getterCalls = 0;
     const setterCalls = [];
@@ -276,33 +275,14 @@ describe('ReactHooksInspection', () => {
       },
     };
 
-    let didCatch = false;
-    expect(() => {
-      // mock the Error constructor to check the internal of the error instance
-      try {
-        ReactDebugTools.inspectHooks(Foo, {}, FakeDispatcherRef);
-      } catch (error) {
-        expect(error.message).toBe('Error rendering inspected component');
-        // error.cause is the original error
-        expect(error.cause).toBeInstanceOf(Error);
-        expect(error.cause.message).toBe(
-          "Cannot read property 'useState' of null",
-        );
-      }
-      didCatch = true;
-    }).toErrorDev(
-      'Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for' +
-        ' one of the following reasons:\n' +
-        '1. You might have mismatching versions of React and the renderer (such as React DOM)\n' +
-        '2. You might be breaking the Rules of Hooks\n' +
-        '3. You might have more than one copy of React in the same app\n' +
-        'See https://reactjs.org/link/invalid-hook-call for tips about how to debug and fix this problem.',
-      {withoutStack: true},
-    );
-    // avoid false positive if no error was thrown at all
-    expect(didCatch).toBe(true);
+    function Foo(props) {
+      const [state] = FakeDispatcherRef.current.useState('hello world');
+      return <div>{state}</div>;
+    }
+
+    ReactDebugTools.inspectHooks(Foo, {}, FakeDispatcherRef);
 
-    expect(getterCalls).toBe(1);
+    expect(getterCalls).toBe(2);
     expect(setterCalls).toHaveLength(2);
     expect(setterCalls[0]).not.toBe(initial);
     expect(setterCalls[1]).toBe(initial);
