Generate source map for server actions in ESM loader

sebmarkbage · sebmarkbage · commit 8a42e409cb26 · 2024-08-20T18:33:37.000-04:00
We use the webpack-sources dependency as a utility but it doesn't
use anything from webpack and it's a small dep. Could maybe inline into
build.
diff --git a/fixtures/flight-esm/package.json b/fixtures/flight-esm/package.json
@@ -13,14 +13,15 @@
     "prompts": "^2.4.2",
     "react": "experimental",
     "react-dom": "experimental",
-    "undici": "^5.20.0"
+    "undici": "^5.20.0",
+    "webpack-sources": "^3.2.0"
   },
   "scripts": {
     "predev": "cp -r ../../build/oss-experimental/* ./node_modules/",
     "prestart": "cp -r ../../build/oss-experimental/* ./node_modules/",
     "dev": "concurrently \"npm run dev:region\" \"npm run dev:global\"",
     "dev:global": "NODE_ENV=development BUILD_PATH=dist node server/global",
-    "dev:region": "NODE_ENV=development BUILD_PATH=dist nodemon --watch src --watch dist -- --experimental-loader ./loader/region.js --conditions=react-server server/region",
+    "dev:region": "NODE_ENV=development BUILD_PATH=dist nodemon --watch src --watch dist -- --enable-source-maps --experimental-loader ./loader/region.js --conditions=react-server server/region",
     "start": "concurrently \"npm run start:region\" \"npm run start:global\"",
     "start:global": "NODE_ENV=production node server/global",
     "start:region": "NODE_ENV=production node --experimental-loader ./loader/region.js --conditions=react-server server/region"
diff --git a/fixtures/flight-esm/yarn.lock b/fixtures/flight-esm/yarn.lock
@@ -755,6 +755,11 @@ vary@~1.1.2:
   resolved "https://registry.yarnpkg.com/vary/-/vary-1.1.2.tgz#2299f02c6ded30d4a5961b0b9f74524a18f634fc"
   integrity sha512-BNGbWLfd0eUPabhkXUVm0j8uuvREyTh5ovRa/dyow/BqAbZJyC+5fU+IzQOzmAKzYqYRAISoRhdQr3eIZ/PXqg==
 
+webpack-sources@^3.2.0:
+  version "3.2.3"
+  resolved "https://registry.yarnpkg.com/webpack-sources/-/webpack-sources-3.2.3.tgz#2d4daab8451fd4b240cc27055ff6a0c2ccea0cde"
+  integrity sha512-/DyMEOrDgLKKIG0fmvtz+4dUX/3Ghozwgm6iPp8KRhvn+eQf9+Q7GWxVNMk3+uCPWfdXYC4ExGBckIXdFEfH1w==
+
 wrap-ansi@^7.0.0:
   version "7.0.0"
   resolved "https://registry.yarnpkg.com/wrap-ansi/-/wrap-ansi-7.0.0.tgz#67e145cff510a6a6984bdf1152911d69d2eb9e43"
diff --git a/packages/react-server-dom-esm/package.json b/packages/react-server-dom-esm/package.json
@@ -58,6 +58,7 @@
     "react-dom": "^19.0.0"
   },
   "dependencies": {
-    "acorn-loose": "^8.3.0"
+    "acorn-loose": "^8.3.0",
+    "webpack-sources": "^3.2.0"
   }
 }
diff --git a/packages/react-server-dom-esm/src/ReactFlightESMNodeLoader.js b/packages/react-server-dom-esm/src/ReactFlightESMNodeLoader.js

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,7 @@`
`58`	`58`	`"react-dom": "^19.0.0"`
`59`	`59`	`},`
`60`	`60`	`"dependencies": {`
`61`		`- "acorn-loose": "^8.3.0"`
	`61`	`+ "acorn-loose": "^8.3.0",`
	`62`	`+ "webpack-sources": "^3.2.0"`
`62`	`63`	`}`
`63`	`64`	`}`