Skip to content

Commit 091d7fd

Browse files
committed
Tweaked some test names after @gaearon review comment #9221 (comment) . Also realized that one of the tests was essentially a direct copy of another, so deleted it.
1 parent 2781c49 commit 091d7fd

File tree

4 files changed

+131
-153
lines changed

4 files changed

+131
-153
lines changed

scripts/fiber/tests-failing.txt

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -48,27 +48,26 @@ src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
4848
* renders no HTML events with client render on top of good server markup
4949
* renders a div with text with client render on top of good server markup
5050
* renders a div with text with flanking whitespace with client render on top of good server markup
51-
* renders a div with text with client render on top of good server markup
52-
* renders a div with blank text child with client render on top of good server markup
53-
* renders renders a div with blank text children with server string render
54-
* renders renders a div with blank text children with client render on top of good server markup
55-
* renders a div with whitespace children with server string render
56-
* renders a div with whitespace children with client render on top of good server markup
51+
* renders a div with text child in brackets with client render on top of good server markup
52+
* renders a div with an empty text child with client render on top of good server markup
53+
* renders a div with multiple empty text children with server string render
54+
* renders a div with multiple empty text children with client render on top of good server markup
55+
* renders a div with multiple whitespace children with server string render
56+
* renders a div with multiple whitespace children with client render on top of good server markup
5757
* renders a div with text sibling to a node with server string render
5858
* renders a div with text sibling to a node with client render on top of good server markup
5959
* renders a non-standard element with text with client render on top of good server markup
6060
* renders a custom element with text with client render on top of good server markup
61-
* renders leading blank children with comments when there are multiple children with server string render
62-
* renders leading blank children with comments when there are multiple children with client render on top of good server markup
63-
* renders trailing blank children with comments when there are multiple children with server string render
64-
* renders trailing blank children with comments when there are multiple children with client render on top of good server markup
65-
* renders an element with just one text child without comments with client render on top of good server markup
66-
* renders an element with two text children with comments with server string render
67-
* renders an element with two text children with comments with client render on top of good server markup
61+
* renders a leading blank child with a text sibling with server string render
62+
* renders a leading blank child with a text sibling with client render on top of good server markup
63+
* renders a trailing blank child with a text sibling with server string render
64+
* renders a trailing blank child with a text sibling with client render on top of good server markup
65+
* renders an element with two text children with server string render
66+
* renders an element with two text children with client render on top of good server markup
6867
* renders a number as single child with client render on top of good server markup
6968
* renders zero as single child with client render on top of good server markup
70-
* renders an element with number and text children with comments with server string render
71-
* renders an element with number and text children with comments with client render on top of good server markup
69+
* renders an element with number and text children with server string render
70+
* renders an element with number and text children with client render on top of good server markup
7271
* renders null single child as blank with client render on top of good server markup
7372
* renders false single child as blank with client render on top of good server markup
7473
* renders undefined single child as blank with client render on top of good server markup
@@ -100,8 +99,8 @@ src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
10099
* renders a div with multiple children with client render on top of good server markup
101100
* renders a div with multiple children separated by whitespace with server string render
102101
* renders a div with multiple children separated by whitespace with client render on top of good server markup
103-
* renders a div with a child surrounded by whitespace with server string render
104-
* renders a div with a child surrounded by whitespace with client render on top of good server markup
102+
* renders a div with a single child surrounded by whitespace with server string render
103+
* renders a div with a single child surrounded by whitespace with client render on top of good server markup
105104
* renders >,<, and & as single child with client render on top of good server markup
106105
* renders >,<, and & as multiple children with server string render
107106
* renders >,<, and & as multiple children with client render on top of good server markup

scripts/fiber/tests-passing-except-dev.txt

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -49,20 +49,19 @@ src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
4949
* renders no HTML events with client render on top of bad server markup
5050
* renders a div with text with client render on top of bad server markup
5151
* renders a div with text with flanking whitespace with client render on top of bad server markup
52-
* renders a div with text with client render on top of bad server markup
53-
* renders a div with blank text child with client render on top of bad server markup
54-
* renders renders a div with blank text children with client render on top of bad server markup
55-
* renders a div with whitespace children with client render on top of bad server markup
52+
* renders a div with text child in brackets with client render on top of bad server markup
53+
* renders a div with an empty text child with client render on top of bad server markup
54+
* renders a div with multiple empty text children with client render on top of bad server markup
55+
* renders a div with multiple whitespace children with client render on top of bad server markup
5656
* renders a div with text sibling to a node with client render on top of bad server markup
5757
* renders a non-standard element with text with client render on top of bad server markup
5858
* renders a custom element with text with client render on top of bad server markup
59-
* renders leading blank children with comments when there are multiple children with client render on top of bad server markup
60-
* renders trailing blank children with comments when there are multiple children with client render on top of bad server markup
61-
* renders an element with just one text child without comments with client render on top of bad server markup
62-
* renders an element with two text children with comments with client render on top of bad server markup
59+
* renders a leading blank child with a text sibling with client render on top of bad server markup
60+
* renders a trailing blank child with a text sibling with client render on top of bad server markup
61+
* renders an element with two text children with client render on top of bad server markup
6362
* renders a number as single child with client render on top of bad server markup
6463
* renders zero as single child with client render on top of bad server markup
65-
* renders an element with number and text children with comments with client render on top of bad server markup
64+
* renders an element with number and text children with client render on top of bad server markup
6665
* renders null single child as blank with client render on top of bad server markup
6766
* renders false single child as blank with client render on top of bad server markup
6867
* renders undefined single child as blank with client render on top of bad server markup
@@ -89,7 +88,7 @@ src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
8988
* renders a div with a child with client render on top of bad server markup
9089
* renders a div with multiple children with client render on top of bad server markup
9190
* renders a div with multiple children separated by whitespace with client render on top of bad server markup
92-
* renders a div with a child surrounded by whitespace with client render on top of bad server markup
91+
* renders a div with a single child surrounded by whitespace with client render on top of bad server markup
9392
* renders >,<, and & as single child with client render on top of bad server markup
9493
* renders >,<, and & as multiple children with client render on top of bad server markup
9594
* throws when rendering a string component with clean client render

scripts/fiber/tests-passing.txt

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1142,27 +1142,25 @@ src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
11421142
* renders a div with text with clean client render
11431143
* renders a div with text with flanking whitespace with server string render
11441144
* renders a div with text with flanking whitespace with clean client render
1145-
* renders a div with text with server string render
1146-
* renders a div with text with clean client render
1147-
* renders a div with blank text child with server string render
1148-
* renders a div with blank text child with clean client render
1149-
* renders renders a div with blank text children with clean client render
1150-
* renders a div with whitespace children with clean client render
1145+
* renders a div with text child in brackets with server string render
1146+
* renders a div with text child in brackets with clean client render
1147+
* renders a div with an empty text child with server string render
1148+
* renders a div with an empty text child with clean client render
1149+
* renders a div with multiple empty text children with clean client render
1150+
* renders a div with multiple whitespace children with clean client render
11511151
* renders a div with text sibling to a node with clean client render
11521152
* renders a non-standard element with text with server string render
11531153
* renders a non-standard element with text with clean client render
11541154
* renders a custom element with text with server string render
11551155
* renders a custom element with text with clean client render
1156-
* renders leading blank children with comments when there are multiple children with clean client render
1157-
* renders trailing blank children with comments when there are multiple children with clean client render
1158-
* renders an element with just one text child without comments with server string render
1159-
* renders an element with just one text child without comments with clean client render
1160-
* renders an element with two text children with comments with clean client render
1156+
* renders a leading blank child with a text sibling with clean client render
1157+
* renders a trailing blank child with a text sibling with clean client render
1158+
* renders an element with two text children with clean client render
11611159
* renders a number as single child with server string render
11621160
* renders a number as single child with clean client render
11631161
* renders zero as single child with server string render
11641162
* renders zero as single child with clean client render
1165-
* renders an element with number and text children with comments with clean client render
1163+
* renders an element with number and text children with clean client render
11661164
* renders null single child as blank with server string render
11671165
* renders null single child as blank with clean client render
11681166
* renders false single child as blank with server string render
@@ -1210,7 +1208,7 @@ src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
12101208
* renders a div with multiple children with server string render
12111209
* renders a div with multiple children with clean client render
12121210
* renders a div with multiple children separated by whitespace with clean client render
1213-
* renders a div with a child surrounded by whitespace with clean client render
1211+
* renders a div with a single child surrounded by whitespace with clean client render
12141212
* renders >,<, and & as single child with server string render
12151213
* renders >,<, and & as single child with clean client render
12161214
* renders >,<, and & as multiple children with clean client render

0 commit comments

Comments
 (0)