Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/ktfmt
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e563773
Choose a base ref
...
head repository: facebook/ktfmt
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ea81882
Choose a head ref
  • 14 commits
  • 13 files changed
  • 5 contributors

Commits on May 4, 2022

  1. Bump version to 0.38-SNAPSHOT

    Differential Revision: D36123500
    
    fbshipit-source-id: df1032523e6645646cd70e3e23e9c8e3e4e80560
    cgrushko authored and facebook-github-bot committed May 4, 2022
    Configuration menu
    Copy the full SHA
    687b6f7 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. Handle lambda destructuring declarations with explicit type

    Summary: Fixes #317
    
    Reviewed By: hick209
    
    Differential Revision: D36188965
    
    fbshipit-source-id: 744b503691fea24eb857218786a1191a2f16f4ce
    strulovich authored and facebook-github-bot committed May 6, 2022
    Configuration menu
    Copy the full SHA
    b7ff8ba View commit details
    Browse the repository at this point in the history
  2. Disabling grouping of fields after the first group in qualified expre…

    …ssions
    
    Summary: This addresses the request to not try and pack fields in a qualified expression after the first grouping.
    
    Reviewed By: hick209
    
    Differential Revision: D36202571
    
    fbshipit-source-id: 4e342ce1917a9a7a3d3fcdb229b613752d02b941
    strulovich authored and facebook-github-bot committed May 6, 2022
    Configuration menu
    Copy the full SHA
    63eef56 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2022

  1. Update ktfmt component on FBS:master

    Reviewed By: strulovich
    
    Differential Revision: D36123426
    
    fbshipit-source-id: 32cb667623564a38def123d20b88179bffe20cdb
    cgrushko authored and facebook-github-bot committed May 8, 2022
    Configuration menu
    Copy the full SHA
    bd2e5c7 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. Add line breaks to lambdas after broken function arguments

    Summary:
    We've had some requests to format this:
    
    ```
    foo.bar(
      trailingComma,
    ) { x = 0 }
    ```
    
    As this:
    ```
    foo.bar(
      trailingComma,
    ) {
      x = 0
    }
    ```
    
    Here I do that by keeping track of when we enter lambda arguments in call elements and noting if there's a trailing comma.
    
    ## Caveat
    
    **Google-style requires a trailing comma**
    
    The Google-style formatting puts the closing paren on the next line, even when there's no trailing comma. Due to this we can't detect that we need to put a break in the lambda.
    
    This could be fixed by detecting if the params broke (instead of looking for a trailing comma) but I'm not sure how to do that.
    
    Reviewed By: strulovich
    
    Differential Revision: D36649191
    
    fbshipit-source-id: 2c8d316f068c1030437af59b5114ffae9d5d2aa8
    davidtorosyan authored and facebook-github-bot committed May 26, 2022
    Configuration menu
    Copy the full SHA
    c0e6243 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2022

  1. Fix breaking before is keyword causing illegal code

    Summary:
    This should resolve #315
    
    Tried to avoid changing code in too many places by looking at the parent.
    
    Reviewed By: davidtorosyan
    
    Differential Revision: D36783125
    
    fbshipit-source-id: 54fcbdc7372f9147925b2746aa73e61fc06346d3
    strulovich authored and facebook-github-bot committed May 31, 2022
    1 Configuration menu
    Copy the full SHA
    24e6942 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. For --google_style, break between ( and long condition expressions (#325

    )
    
    Summary:
    Fixes #319
    
    Pull Request resolved: #325
    
    Reviewed By: strulovich
    
    Differential Revision: D36929348
    
    Pulled By: cgrushko
    
    fbshipit-source-id: 48f649a7edf08e58cdea7b6a620132c62807c0e4
    nreid260 authored and facebook-github-bot committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    44bf14c View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Bump version to 0.38

    Differential Revision: D36805239
    
    fbshipit-source-id: 39a798e290c85a8092cf6a70360d31216c97f20b
    cgrushko authored and facebook-github-bot committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    9bfe60c View commit details
    Browse the repository at this point in the history
  2. Bump version to 0.39-SNAPSHOT

    Differential Revision: D36805238
    
    fbshipit-source-id: 0f815d63df3e90dc3715d7b3b0832eca0b882542
    cgrushko authored and facebook-github-bot committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    e40bc15 View commit details
    Browse the repository at this point in the history
  3. Support shebang for KTS files

    Summary: This was crashing in JavaInput, so let's just remove it and add it back at the end.
    
    Reviewed By: cortinico
    
    Differential Revision: D36987246
    
    fbshipit-source-id: e404d213d9ba5a916caaa63cba850066d1d77436
    strulovich authored and facebook-github-bot committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    d71487b View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. Prevent adjacent unary operators from merging (#328)

    Summary: Pull Request resolved: #328
    
    Reviewed By: strulovich
    
    Differential Revision: D37003050
    
    Pulled By: cgrushko
    
    fbshipit-source-id: 010cd6a400d88aed8e253718658ec93464dd0b5f
    nreid260 authored and facebook-github-bot committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    4a0c2d4 View commit details
    Browse the repository at this point in the history
  2. Format .kts files with ktfmt

    Summary:
    I'm extending ktfmt setup to run on kotlin script files as well.
    
    Changelog:
    [Internal] [Changed] - Reformat .kts files with ktfmt
    
    skip-linter-coverage-verification
    
    Reviewed By: zertosh
    
    Differential Revision: D36967010
    
    fbshipit-source-id: a83f3facbb5f30b935b69fc70a5588e4da5996b2
    cortinico authored and facebook-github-bot committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    0b5d3d1 View commit details
    Browse the repository at this point in the history
  3. Handle escaped markdown characters in KDoc

    Summary:
    We never encountered that until now, so all it required was handling this case as well.
    
    Fixes #329
    
    Reviewed By: cgrushko
    
    Differential Revision: D37038044
    
    fbshipit-source-id: 21d89dc7186f6e46369980d94a97da8548a0f793
    strulovich authored and facebook-github-bot committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    5f7b063 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Bump version to 0.39

    Differential Revision: D37169627
    
    fbshipit-source-id: adc1a9ad44105787470e88ff6942f5f2a84cb4c3
    cgrushko authored and facebook-github-bot committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    ea81882 View commit details
    Browse the repository at this point in the history
Loading