[enums] Add parameter names to enum proto methods

gkz · facebook-github-bot · commit 9c3e00b9c36a · 2020-03-11T16:53:19.000-07:00
Summary: Just noticed that it looks a bit nicer in the IDE (e.g. signature help) if the methods have a parameter name (see test plan).

Reviewed By: panagosg7

Differential Revision: D20396188

fbshipit-source-id: c6d16c238348e313d024e4752638e6c36f28da18
diff --git a/lib/core.js b/lib/core.js
@@ -936,8 +936,8 @@ declare var console: {
 };
 
 type $EnumProto<TEnum, TRepresentation> = {|
-  cast(TRepresentation): void | TEnum,
-  isValid(TRepresentation): boolean,
+  cast(input: TRepresentation): void | TEnum,
+  isValid(input: TRepresentation): boolean,
   members(): Iterable<TEnum>,
   __proto__: null,
 |}
diff --git a/tests/autocomplete/autocomplete.exp b/tests/autocomplete/autocomplete.exp
@@ -3032,27 +3032,27 @@ enums.js = {
 {
   "label":"cast",
   "kind":3,
-  "detail":"(string) => (void | E)",
-  "inlineDetail":"(_: string)",
+  "detail":"(input: string) => (void | E)",
+  "inlineDetail":"(input: string)",
   "itemType":"void | E",
   "sortText":"00000000000000000001",
   "insertTextFormat":2,
   "textEdit":{
     "range":{"start":{"line":9,"character":2},"end":{"line":9,"character":2}},
-    "newText":"cast(${1:_})"
+    "newText":"cast(${1:input})"
   }
 }
 {
   "label":"isValid",
   "kind":3,
-  "detail":"(string) => boolean",
-  "inlineDetail":"(_: string)",
+  "detail":"(input: string) => boolean",
+  "inlineDetail":"(input: string)",
   "itemType":"boolean",
   "sortText":"00000000000000000001",
   "insertTextFormat":2,
   "textEdit":{
     "range":{"start":{"line":9,"character":2},"end":{"line":9,"character":2}},
-    "newText":"isValid(${1:_})"
+    "newText":"isValid(${1:input})"
   }
 }
 {
diff --git a/tests/enums/enums.exp b/tests/enums/enums.exp
@@ -1635,8 +1635,8 @@ References:
    <BUILTINS>/core.js:938:43
                                                   v-
    938| type $EnumProto<TEnum, TRepresentation> = {|
-   939|   cast(TRepresentation): void | TEnum,
-   940|   isValid(TRepresentation): boolean,
+   939|   cast(input: TRepresentation): void | TEnum,
+   940|   isValid(input: TRepresentation): boolean,
    941|   members(): Iterable<TEnum>,
    942|   __proto__: null,
    943| |}
@@ -1655,8 +1655,8 @@ References:
    <BUILTINS>/core.js:938:43
                                                   v-
    938| type $EnumProto<TEnum, TRepresentation> = {|
-   939|   cast(TRepresentation): void | TEnum,
-   940|   isValid(TRepresentation): boolean,
+   939|   cast(input: TRepresentation): void | TEnum,
+   940|   isValid(input: TRepresentation): boolean,
    941|   members(): Iterable<TEnum>,
    942|   __proto__: null,
    943| |}
@@ -1693,8 +1693,8 @@ References:
    <BUILTINS>/core.js:938:43
                                                   v-
    938| type $EnumProto<TEnum, TRepresentation> = {|
-   939|   cast(TRepresentation): void | TEnum,
-   940|   isValid(TRepresentation): boolean,
+   939|   cast(input: TRepresentation): void | TEnum,
+   940|   isValid(input: TRepresentation): boolean,
    941|   members(): Iterable<TEnum>,
    942|   __proto__: null,
    943| |}
@@ -1713,8 +1713,8 @@ References:
    <BUILTINS>/core.js:938:43
                                                   v-
    938| type $EnumProto<TEnum, TRepresentation> = {|
-   939|   cast(TRepresentation): void | TEnum,
-   940|   isValid(TRepresentation): boolean,
+   939|   cast(input: TRepresentation): void | TEnum,
+   940|   isValid(input: TRepresentation): boolean,
    941|   members(): Iterable<TEnum>,
    942|   __proto__: null,
    943| |}

Original file line number	Diff line number	Diff line change
`@@ -3032,27 +3032,27 @@ enums.js = {`
`3032`	`3032`	`{`
`3033`	`3033`	`"label":"cast",`
`3034`	`3034`	`"kind":3,`
`3035`		`- "detail":"(string) => (void \| E)",`
`3036`		`- "inlineDetail":"(_: string)",`
	`3035`	`+ "detail":"(input: string) => (void \| E)",`
	`3036`	`+ "inlineDetail":"(input: string)",`
`3037`	`3037`	`"itemType":"void \| E",`
`3038`	`3038`	`"sortText":"00000000000000000001",`
`3039`	`3039`	`"insertTextFormat":2,`
`3040`	`3040`	`"textEdit":{`
`3041`	`3041`	`"range":{"start":{"line":9,"character":2},"end":{"line":9,"character":2}},`
`3042`		`- "newText":"cast(${1:_})"`
	`3042`	`+ "newText":"cast(${1:input})"`
`3043`	`3043`	`}`
`3044`	`3044`	`}`
`3045`	`3045`	`{`
`3046`	`3046`	`"label":"isValid",`
`3047`	`3047`	`"kind":3,`
`3048`		`- "detail":"(string) => boolean",`
`3049`		`- "inlineDetail":"(_: string)",`
	`3048`	`+ "detail":"(input: string) => boolean",`
	`3049`	`+ "inlineDetail":"(input: string)",`
`3050`	`3050`	`"itemType":"boolean",`
`3051`	`3051`	`"sortText":"00000000000000000001",`
`3052`	`3052`	`"insertTextFormat":2,`
`3053`	`3053`	`"textEdit":{`
`3054`	`3054`	`"range":{"start":{"line":9,"character":2},"end":{"line":9,"character":2}},`
`3055`		`- "newText":"isValid(${1:_})"`
	`3055`	`+ "newText":"isValid(${1:input})"`
`3056`	`3056`	`}`
`3057`	`3057`	`}`
`3058`	`3058`	`{`