This repository was archived by the owner on Sep 26, 2025. It is now read-only.
[Breaking] Enforce minimum Node JS to v18#4897
Closed
Pranav-yadav wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
Member
|
There are a few CI issues with our sub-projects. Could you take a look? |
Member
|
Ohh, sorry. This is a stack! |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 30, 2023
Summary: This diff bumps Node JS to `v18` in CI Pipeline. Related PR: 1. #4897 ## Changelog [General] [Changed] - Bump Node JS to `v18` in CI Pipeline Pull Request resolved: #4898 Test Plan: - Should pass tests & builds successfully Reviewed By: lblasa Differential Revision: D47128828 Pulled By: passy fbshipit-source-id: b8d829b273898bf5e297560fbbdbafba80285b33
Pranav-yadav
force-pushed
the
Pranav-yadav/bump-node18
branch
from
July 1, 2023 05:44
b52bd18 to
eed25fa
Compare
Contributor
Author
Np. |
Contributor
Author
Contributor
|
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Member
|
Woohoo! Let's ship it. |
Contributor
|
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
Thanks for review ❤️. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Enforce minimum Node JS version to
v18via/package.json#enginesNode JS
v16's EOL is2023-09-11:https://nodejs.org/en/blog/announcements/nodejs16-eol
react-native also bumped Node JS to
v18recently Breaking - Bump minimum Node version from 16 to 18 react/react-native#37709 (RN0.73will probably enforce min Node JSv18)Bumps in CI via:
v18in CI Pipeline #4898Changelog:
[General] [Breaking] - Enforce minimum Node JS
v18Test Plan: