refactor(core): improve dev perf, fine-grained site reloads - part2#9968
Merged
refactor(core): improve dev perf, fine-grained site reloads - part2#9968
Conversation
slorber
added
pr: performance
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 992 kB ℹ️ View Unchanged
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
…-p2' into slorber/fine-grained-site-reload-p2
This was referenced May 19, 2024
This was referenced Aug 12, 2024
This was referenced Aug 15, 2024
This was referenced Aug 27, 2024
This was referenced Sep 4, 2024
This was referenced Sep 8, 2024
This was referenced Sep 11, 2024
This was referenced Sep 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is a follow-up of the DX improvements started in #9903
The goal of this is to improve the dev experience performance.
Previously if you edited a
docs/intro.mdxfile, all the plugins lifecyclecontentLoaded()would run.Now, when editing a doc file, only the doc plugin instance
contentLoaded()lifecycle will run, preventing useless expensive calls and IOs on other unrelated plugins.Test Plan
Unit tests + dogfood
Test links
https://deploy-preview-9968--docusaurus-2.netlify.app/
Related issues/PRs
This is possible thanks to the introducing of a new
allContentLoaded()lifecycle in #9931Unlike
contentLoaded(), this lifecycle has to re-run whenever any plugin content change. Thankfully, many plugins (including our 3 content plugins) do not have to implement this lifecycle.