fix(content-blog): add baseUrl for author.image_url#9581
Merged
slorber merged 4 commits intofacebook:mainfrom Dec 5, 2023
Merged
fix(content-blog): add baseUrl for author.image_url#9581slorber merged 4 commits intofacebook:mainfrom
slorber merged 4 commits intofacebook:mainfrom
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
slorber
added
pr: bug fix
slorber
requested changes
Nov 26, 2023
Collaborator
slorber
left a comment
slorber
left a comment
There was a problem hiding this comment.
Thanks, almost good but a few changes needed
Josh-Cena
reviewed
Nov 27, 2023
Collaborator
Josh-Cena
left a comment
Josh-Cena
left a comment
There was a problem hiding this comment.
Do we have tests for local image URLs (like image: ./file.png)? What's the current behavior, for front matter and for authors.yml?
Collaborator
I don't think we have good tests for that apart dogfooding it on our own website. Now that we expose front matter to remark plugins we can probably provide a better implementation of the "markdown assets" thing, but that's a separate issue to work on I don't think either we support local images for |
Collaborator
|
Maybe it's just me but I'm using the static folder less and less—bundling everything seems more organized to me. Even with |
slorber
added
the
Argos
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Collaborator
agree, but we don't really support that currently. That's worth exploring how to implement this in another PR LGTM thanks @OzakIOne 👍 |
slorber
approved these changes
Dec 5, 2023
slorber
pushed a commit
that referenced
this pull request
Jan 5, 2024
slorber
added a commit
that referenced
this pull request
Jan 5, 2024
Co-authored-by: Joshua Chen <[email protected]> Co-authored-by: sebastienlorber <[email protected]> Co-authored-by: Sébastien Lorber <[email protected]> Co-authored-by: Ivan Mar (sOkam!) <[email protected]> Co-authored-by: c0h1b4 <[email protected]> Co-authored-by: Janessa Garrow <[email protected]> Co-authored-by: ozaki <[email protected]> Co-authored-by: axmmisaka <[email protected]> Co-authored-by: Tatsunori Uchino <[email protected]> Co-authored-by: Simen Bekkhus <[email protected]> fix(i18n): complete translations for theme-common.json Brazilian Portuguese (pt-BR) (#9477) fix(content-blog): add baseUrl for author.image_url (#9581) fix(type-aliases): add `title` prop for imported inline SVG React components (#9612) fix(utils): Markdown link replacement with <> but no spaces (#9617) fix(live-codeblock): stabilize react-live transformCode callback, fix editor/preview desync (#9631) fix(cli): output help when no conventional config + no subcommand (#9648) fix CI job (#9604) fix Lint Autofix workflow (#9632) fix(pwa-plugin): upgrade workbox (#9668) fix(create-docusaurus): fix init template code blocks, and little improvements (#9696) fix(theme): allow empty code blocks and live playgrounds (#9704)
slorber
added
backported
slorber
added a commit
that referenced
this pull request
Jan 26, 2024
Co-authored-by: Joshua Chen <[email protected]> Co-authored-by: Joey Clover <[email protected]> Co-authored-by: reece-white <[email protected]> Co-authored-by: Shreesh Nautiyal <[email protected]> Co-authored-by: Nick Gerleman <[email protected]> Co-authored-by: Chongyi Zheng <[email protected]> Co-authored-by: MCR Studio <[email protected]> Co-authored-by: sebastienlorber <[email protected]> Co-authored-by: Sébastien Lorber <[email protected]> Co-authored-by: Ivan Mar (sOkam!) <[email protected]> Co-authored-by: c0h1b4 <[email protected]> Co-authored-by: Janessa Garrow <[email protected]> Co-authored-by: ozaki <[email protected]> Co-authored-by: axmmisaka <[email protected]> Co-authored-by: Tatsunori Uchino <[email protected]> Co-authored-by: Simen Bekkhus <[email protected]> Co-authored-by: Sanjaiyan Parthipan <[email protected]> Co-authored-by: Jack Robson <[email protected]> Co-authored-by: dawei-wang <[email protected]> Co-authored-by: eitsupi <[email protected]> fix(create-docusaurus): fix readme docusaurus 2 ref (#9487) fix(theme): fix firefox CSS :has() support bug (#9530) fix(theme): docs html sidebar items should always be visible (#9531) fix: v3 admonitions should support v2 title syntax for nested admonitions (#9535) fix(theme-classic): fixed wrong cursor on dropdown menu in navbar, when window is small (#9398) fix(theme): upgrade prism-react-renderer, fix html script and style tag highlighting (#9567) fix: add v2 retrocompatible support for quoted admonitions (#9570) fix(i18n): complete translations for theme-common.json Brazilian Portuguese (pt-BR) (#9477) fix(content-blog): add baseUrl for author.image_url (#9581) fix(type-aliases): add `title` prop for imported inline SVG React components (#9612) fix(utils): Markdown link replacement with <> but no spaces (#9617) fix(live-codeblock): stabilize react-live transformCode callback, fix editor/preview desync (#9631) fix(cli): output help when no conventional config + no subcommand (#9648) fix CI job (#9604) fix Lint Autofix workflow (#9632) fix(pwa-plugin): upgrade workbox (#9668) fix(create-docusaurus): fix init template code blocks, and little improvements (#9696) fix(theme): allow empty code blocks and live playgrounds (#9704) fix(core): various broken anchor link fixes (#9732) fix: remove old useless mdx typedefs (#9733) fix(theme-common): fix missing code block MagicComments style in Visual Basic (.NET) 16 (#9727) fix(core): conditionally include `hostname` parameter when using… (#9407) fix(create-docusaurus): fix typo in init template sample docs (#9783) fix(mdx-loader): allow spaces before `mdx-code-block` info string (#9776) fix(core): links with target "_blank" should no be checked by the broken link checker (#9788) fix(core): broken links optimization behaves differently than non-optimized logic (#9791)
This was referenced Jun 8, 2024
This was referenced Jun 14, 2024
This was referenced Jun 16, 2024
This was referenced Jun 20, 2024
This was referenced Jul 17, 2024
This was referenced Jul 21, 2024
This was referenced Jul 21, 2024
This was referenced Aug 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Fix: #9577
Test Plan
Local builds & unit tests
Test links
Deploy preview: https://deploy-preview-9581--docusaurus-2.netlify.app/
Related issues/PRs
#9577