Skip to content

Comments

chore: upgrade prism-react-renderer to 2.3.0 to avoid older clsx#9572

Merged
slorber merged 2 commits intofacebook:mainfrom
harryzcy:prism-react-renderer-2.3
Nov 21, 2023
Merged

chore: upgrade prism-react-renderer to 2.3.0 to avoid older clsx#9572
slorber merged 2 commits intofacebook:mainfrom
harryzcy:prism-react-renderer-2.3

Conversation

@harryzcy
Copy link
Contributor

@harryzcy harryzcy commented Nov 21, 2023 •
edited
Loading

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Address double clsx lib issue. See #9464 (comment)

Test Plan

Test links

Deploy preview: https://deploy-preview-9572--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 21, 2023
@netlify
Copy link

netlify bot commented Nov 21, 2023 •
edited
Loading

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit c134151
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/655d14071e6b880008ff0a1b
😎 Deploy Preview https://deploy-preview-9572--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Nov 21, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 64 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/installation 🟠 87 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/category/getting-started 🟠 76 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog 🟠 74 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 🟢 97 🟢 100 🟢 100 🟠 89 Report
/blog/tags/release 🟠 73 🟢 100 🟢 100 🟠 80 🟠 89 Report
/blog/tags 🟠 77 🟢 100 🟢 100 🟢 90 🟠 89 Report

@slorber slorber added pr: dependencies Pull requests that update a dependency file to backport This PR is planned to be backported to a stable version of Docusaurus labels Nov 21, 2023
@slorber slorber changed the title Upgrade prism-react-renderer to 2.3.0 to avoid older clsx chore: upgrade prism-react-renderer to 2.3.0 to avoid older clsx Nov 21, 2023
@slorber slorber merged commit bda8f14 into facebook:main Nov 21, 2023
@harryzcy harryzcy deleted the prism-react-renderer-2.3 branch November 21, 2023 22:48
slorber pushed a commit that referenced this pull request Nov 30, 2023
@harryzcy @slorber
chore: upgrade prism-react-renderer to 2.3.0 to avoid older clsx (#9572)
b1c2645
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Nov 30, 2023
@argos-ci
Copy link

argos-ci bot commented Nov 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Nov 30, 2023, 6:56 PM

@Abuchtela Abuchtela mentioned this pull request May 20, 2024
Closed
This was referenced May 26, 2024
Closed
Closed
Closed
This was referenced May 26, 2024
Open
Open
Open
This was referenced Jun 14, 2024
Closed
Closed
This was referenced Jun 15, 2024
Closed
Closed
Closed
@Abuchtela Abuchtela mentioned this pull request Jun 16, 2024
Closed
@Abuchtela Abuchtela mentioned this pull request Jun 17, 2024
Closed
This was referenced Jun 20, 2024
Open
Open
@Abuchtela Abuchtela mentioned this pull request Jun 22, 2024
Closed
This was referenced Jun 22, 2024
Closed
Closed
Merged
This was referenced Jul 21, 2024
Closed
Closed
This was referenced Jul 21, 2024
Open
Open
Open
This was referenced Aug 4, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@lex111 lex111 Awaiting requested review from lex111

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees

No one assigned

Labels

backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@harryzcy @slorber @facebook-github-bot