Skip to content

Comments

chore: Upgrade clsx to 2.0.0#9464

Merged
slorber merged 4 commits intofacebook:mainfrom
harryzcy:clsx-2.0.0
Nov 21, 2023
Merged

chore: Upgrade clsx to 2.0.0#9464
slorber merged 4 commits intofacebook:mainfrom
harryzcy:clsx-2.0.0

Conversation

@harryzcy
Copy link
Contributor

@harryzcy harryzcy commented Oct 28, 2023 •
edited
Loading

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Upgrading clsx to 2.0.0 doesn't seems to effect anything.
According to their release note, the breaking change is "Add "exports" map for native ESM support", which shouldn't effect docusaurus.

Test Plan

Test links

clsx v2.0.0 release note: https://github.com/lukeed/clsx/releases/tag/v2.0.0

Deploy preview: https://deploy-preview-9464--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 28, 2023
@netlify
Copy link

netlify bot commented Oct 28, 2023

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit c6883b8
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/653cc3b44bc3290008283aab
😎 Deploy Preview https://deploy-preview-9464--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 28, 2023 •
edited
Loading

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 941b056
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/655cee73266e2300086fe96b
😎 Deploy Preview https://deploy-preview-9464--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 28, 2023 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 67 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/installation 🟠 87 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog 🟠 73 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 🟢 97 🟢 100 🟢 100 🟠 89 Report
/blog/tags/release 🟠 74 🟢 100 🟢 100 🟠 80 🟠 89 Report
/blog/tags 🟠 77 🟢 100 🟢 100 🟢 90 🟠 89 Report

@slorber slorber added the Argos Add this label to run UI visual regression tests. See argos.yml GH action. label Oct 31, 2023
@argos-ci
Copy link

argos-ci bot commented Oct 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 2 changes Nov 30, 2023, 6:56 PM

@harryzcy
Copy link
Contributor Author

harryzcy commented Nov 13, 2023

@slorber Hi, is there any updates to this?

Josh-Cena
Josh-Cena approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember I had problems before with upgrading, but since it builds fine, I guess it is fine :)

@Josh-Cena Josh-Cena added the pr: dependencies Pull requests that update a dependency file label Nov 13, 2023
@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Nov 21, 2023
@slorber
Copy link
Collaborator

slorber commented Nov 21, 2023

LGTM thanks 👍

I guess it's fine to not consider this as a breaking change considering the impact should be very minimal and usage is mostly internal

@slorber slorber merged commit 2c0bf8a into facebook:main Nov 21, 2023
@slorber
Copy link
Collaborator

slorber commented Nov 21, 2023

Missed it but an unfortunate result of this upgrade is that we now have twice the lib in our client bundle. Wondering if we'll backport this? 🤔

CleanShot 2023-11-21 at 19 37 08@2x

@carloskelly13 any plan to upgrade clsx in prism-react-renderer?

@Josh-Cena
Copy link
Collaborator

Josh-Cena commented Nov 21, 2023

clsx is extremely small so not a huge deal. Upgrading would certainly be better, though.

@harryzcy
Copy link
Contributor Author

harryzcy commented Nov 21, 2023 •
edited
Loading

Opened a PR: FormidableLabs/prism-react-renderer#232

@harryzcy harryzcy deleted the clsx-2.0.0 branch November 21, 2023 19:03
@carloskelly13
Copy link

carloskelly13 commented Nov 21, 2023

@slorber Yeah, we'll get @harryzcy's PR merged in and we'll publish a build. Thanks for getting that in.

@carloskelly13
Copy link

carloskelly13 commented Nov 21, 2023

@slorber Prism React Renderer 2.3.0 with clsx 2.0 is published. https://github.com/FormidableLabs/prism-react-renderer/releases/tag/prism-react-renderer%402.3.0

Thanks @harryzcy for the PR!

@harryzcy harryzcy mentioned this pull request Nov 21, 2023
Merged
3 tasks
@slorber
Copy link
Collaborator

slorber commented Nov 21, 2023

thanks ❤️

slorber pushed a commit that referenced this pull request Nov 30, 2023
@harryzcy @Josh-Cena @slorber
chore: Upgrade clsx to 2.0.0 (#9464)
1875ca4 
Co-authored-by: Joshua Chen <[email protected]>
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Nov 30, 2023
@Abuchtela Abuchtela mentioned this pull request May 20, 2024
Closed
This was referenced May 26, 2024
Closed
Closed
Closed
This was referenced May 26, 2024
Open
Open
Open
This was referenced Jun 14, 2024
Closed
Closed
This was referenced Jun 15, 2024
Closed
Closed
Closed
This was referenced Jun 16, 2024
Closed
Closed
This was referenced Jun 20, 2024
Open
Open
This was referenced Jun 22, 2024
Closed
Merged
@qdraw qdraw mentioned this pull request Jul 21, 2024
Closed
@Abuchtela Abuchtela mentioned this pull request Aug 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@lex111 lex111 Awaiting requested review from lex111

Assignees

No one assigned

Labels

Argos Add this label to run UI visual regression tests. See argos.yml GH action. backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@harryzcy @slorber @Josh-Cena @carloskelly13 @facebook-github-bot