Closed
Conversation
Contributor
Author
|
Not sure if I should push |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Collaborator
Yes, please |
Contributor
Author
|
@Josh-Cena just pushed it. |
Collaborator
|
LGTM but maybe we could wait a bit for this PR to land first as we'll benefit from it soon? |
Contributor
|
fixes #5861 |
Contributor
Author
|
I just updated the PR to require |
3 tasks
Collaborator
|
Closing in favor of #8690 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
I'm a maintainer of https://npmjs.com/package/npm-to-yarn, which is used by
docusaurus-remark-plugin-npm2yarn.Previously,
npm-to-yarndidn't work correctly with NodeNext module resolution. The newest version fixes that.Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs
See bgub/npm-to-yarn#33