Add support for alt text of logo for navbar & footer in translations builds#8551
Closed
Mysterious-Dev wants to merge 6 commits intofacebook:mainfrom
Mysterious-Dev:translations_one
Closed
Add support for alt text of logo for navbar & footer in translations builds#8551Mysterious-Dev wants to merge 6 commits intofacebook:mainfrom Mysterious-Dev:translations_one
Mysterious-Dev wants to merge 6 commits intofacebook:mainfrom
Mysterious-Dev:translations_one
Conversation
Mysterious-Dev
requested review from
Josh-Cena,
lex111 and
slorber
as code owners
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Mysterious-Dev
changed the title
Collaborator
|
curious to know why you decided to close it? 🤔 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
This PR can allow more control for translations by the addition of footer & navbar alt text for logo.
It's a detail but that can be usefull to translate the alt text for footer Logo of docusaurus website (https://github.com/facebook/docusaurus/blob/main/website/docusaurus.config.js#L622) to be more consistent.
Test Plan
Translations tests have been updated for the package
docusaurus-theme-classic^^.Test links
Deploy preview: https://deploy-preview-8551--docusaurus-2.netlify.app/