Skip to content

Comments

fix(theme-classic): content container grow to take all the available space#8463

Merged
slorber merged 3 commits intofacebook:mainfrom
Djunnni:sidebar-layout-grow
Dec 22, 2022
Merged

fix(theme-classic): content container grow to take all the available space#8463
slorber merged 3 commits intofacebook:mainfrom
Djunnni:sidebar-layout-grow

Conversation

@Djunnni
Copy link
Contributor

@Djunnni Djunnni commented Dec 19, 2022 •
edited by slorber
Loading

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

  1. CollapseButton margin style set zero locally fix: button style margin set zero globally #8426
  2. docusaurus-theme-classic/Layout set flex style for grow Docs layout issue: content container does not grow to take all the available space #8369

Test Plan

Related issues/PRs

fix #8369
fix #8426 for CollapseButton

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 19, 2022
@Djunnni Djunnni mentioned this pull request Dec 19, 2022
Closed
7 tasks
@netlify
Copy link

netlify bot commented Dec 19, 2022 •
edited
Loading

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 768870e
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/63a4626d6cd88d000850357a
😎 Deploy Preview https://deploy-preview-8463--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Dec 19, 2022 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 69 🟢 97 🟢 92 🟢 100 🟢 90 Report
/docs/installation 🟠 74 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena Josh-Cena changed the title fix(docusaurus-theme-classic): content container grow to take all the available space by flex fix(theme-classic): content container grow to take all the available space Dec 19, 2022
@Djunnni
Copy link
Contributor Author

Djunnni commented Dec 22, 2022

@slorber
i just changed 3 files. i don't know why Build Size Report is failed.
i run this command in my mac, but it didn't happend
can you help me?

@Djunnni
Copy link
Contributor Author

Djunnni commented Dec 22, 2022

after merge facebook:main into my branch, Build Size Report is successful

This was referenced Dec 22, 2022
Closed
Closed
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Dec 22, 2022
slorber
slorber approved these changes Dec 22, 2022
View reviewed changes
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 perfect, thanks

Good usage of flew-grow, finally our layout uses is the way it's supposed to be 🎊

All pages work fine, including the problematic one is fixed:
https://deploy-preview-8463--docusaurus-2.netlify.app/tests/docs/doc-with-another-sidebar

@slorber slorber merged commit c0102bd into facebook:main Dec 22, 2022
@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Dec 22, 2022
slorber pushed a commit that referenced this pull request Jan 26, 2023
@Djunnni @slorber
fix(theme-classic): content container grow to take all the available …
f3507e0 
…space (#8463)

fix #8369
fix #8426
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Jan 27, 2023
@slorber slorber mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slorber slorber slorber approved these changes

@lex111 lex111 Awaiting requested review from lex111

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees

No one assigned

Labels

backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs layout issue: content container does not grow to take all the available space

3 participants

@Djunnni @slorber @facebook-github-bot