Skip to content

Comments

fix(theme-translations): complete Vietnamese theme translations#8450

Merged
slorber merged 2 commits intofacebook:mainfrom
namnguyenthanhwork:patch-3
Dec 16, 2022
Merged

fix(theme-translations): complete Vietnamese theme translations#8450
slorber merged 2 commits intofacebook:mainfrom
namnguyenthanhwork:patch-3

Conversation

@namnguyenthanhwork
Copy link
Contributor

@namnguyenthanhwork namnguyenthanhwork commented Dec 16, 2022 •
edited
Loading

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 16, 2022
@netlify
Copy link

netlify bot commented Dec 16, 2022 •
edited
Loading

✅ [V2]

Name Link
🔨 Latest commit 8c35d60
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/639c5dccabc186000804d9b8
😎 Deploy Preview https://deploy-preview-8450--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Dec 16, 2022 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 83 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 74 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena Josh-Cena mentioned this pull request Dec 16, 2022
Closed
3 tasks
@slorber slorber changed the title fix(theme-translations): remove extra vi trans fix(theme-translations): complete Vietnamese theme translations Dec 16, 2022
@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Dec 16, 2022
slorber
slorber approved these changes Dec 16, 2022
View reviewed changes
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks 👍

@slorber slorber merged commit f54b6e7 into facebook:main Dec 16, 2022
@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Jan 26, 2023
slorber pushed a commit that referenced this pull request Jan 26, 2023
@namnguyenthanhwork @slorber
fix(theme-translations): complete Vietnamese theme translations #8450
e5b0707
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Jan 27, 2023
@slorber slorber mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slorber slorber slorber approved these changes

@lex111 lex111 Awaiting requested review from lex111

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees

No one assigned

Labels

backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@namnguyenthanhwork @slorber @facebook-github-bot