fix(theme): forward className prop in theme-classic's Heading#8350
Merged
slorber merged 1 commit intofacebook:mainfrom Nov 16, 2022
Merged
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Collaborator
|
:D Apparently this is the only thing that should be done. The TS side already existed and we just did not merge classes properly export interface Props extends ComponentProps<HeadingType> {
readonly as: HeadingType;
}We don't have good tests on the UI, will add a storybook later but it's ok for now 👍 |
slorber
changed the title
slorber
added
the
to backport
slorber
pushed a commit
that referenced
this pull request
Jan 26, 2023
slorber
added
backported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
[ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.Motivation
See #8327.
Apologies for taking a
good first issueafter I've already sent a couple PRs to this repo. I just was excited about this one 😄Test Plan
I tried this out locally on the typescript-eslint/typescript-eslint#5951 PR and it worked.
Test links
I don't see any existing tests for this. What would you like me to do?
Related issues/PRs
Fixes #8327.