fix(utils): allow partially backticked markdown h1 contentTitles#8314
Merged
slorber merged 1 commit intofacebook:mainfrom Nov 17, 2022
Merged
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Collaborator
|
Fun, isn't this function only used for sanitizing metadata like browser tab title? Does it work when rendering? |
Contributor
Author
|
Yeah, this is a start, but I want to try more. Just blocked on #8315 for testing page changes 😄 |
JoshuaKGoldberg
changed the title
Contributor
Author
|
Or, I guess while that gets worked on, can we get this as a partial fix in the meantime? I think this will at least partially improve the situation? |
slorber
added
pr: bug fix
Collaborator
|
👍 thanks Looks like it's working as we want it to:
|
slorber
changed the title
slorber
pushed a commit
that referenced
this pull request
Jan 26, 2023
slorber
added
backported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
See #8294 - I want h1s with inline code please 😄
Test Plan
I ... don't have one beyond unit tests.
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs
#8294 - would you like me to file an issue? Or can someone convert that to one?