fix(mermaid): fix Mermaid integration for v9.2 release#8282
Merged
Conversation
slorber
added
pr: bug fix
7 tasks
|
Hi, A temporary workaround : using Yarn, adding
Thanks @Josh-Cena and @homotechsual on #help-and-questions ;) |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Collaborator
Author
|
The issue has been fixed in Mermaid 9.2.2 and everything seems to work fine again now Had to change a bit the types to make it work again because new official types are not exactly the same as the DefinitivelyTyped ones |
slorber
changed the title
|
Size Change: +12.9 kB (+1%) Total Size: 885 kB
ℹ️ View Unchanged
|
slorber
added a commit
that referenced
this pull request
Jan 26, 2023
slorber
added
backported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading for 9.1.7 to 9.2 makes the Mermaid theme compilation fails
Unfortunately users are upgraded automatically due to using the semver range
^9.1, and it also fails at runtime for these users that should force v9.1.7 (last version that works)See:
Current PR is a draft, still unsolved 😅
Probably unrelated to the issue (according to my local tests) but the theme/client Mermaid apis were not compiled with the correct TS options (ie outputs CJS instead of ESM), so I'm also fixing that here.