feat(eslint-plugin): add plugin to exported configs#8281
Merged
slorber merged 2 commits intofacebook:mainfrom Dec 7, 2022
lachieh:feature/add-eslint-plugin-to-config
Merged
feat(eslint-plugin): add plugin to exported configs#8281slorber merged 2 commits intofacebook:mainfrom lachieh:feature/add-eslint-plugin-to-config
slorber merged 2 commits intofacebook:mainfrom
lachieh:feature/add-eslint-plugin-to-config
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Collaborator
|
@Josh-Cena let me know if you have any opinion on this otherwise I'll review it later. That seems like a reasonable change to do 👍 |
Josh-Cena
changed the title
Josh-Cena
added
pr: polish
Josh-Cena
approved these changes
Dec 3, 2022
Collaborator
Josh-Cena
left a comment
Josh-Cena
left a comment
There was a problem hiding this comment.
This looks great to me. Thanks!
Collaborator
|
Thanks 👍 |
slorber
pushed a commit
that referenced
this pull request
Jan 26, 2023
Co-authored-by: Joshua Chen <[email protected]> closes undefined Closes #8280
slorber
added
backported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
See #8280 for details
Test Plan
Change to config might require a minor version change.
Test links
Related issues/PRs
Closes #8280