✅ [V2]

Name	Link
🔨 Latest commit	2a05d0b
🔍 Latest deploy log	https://app.netlify.com/sites/docusaurus-2/deploys/626bab83e99c1b0008fc8e55
😎 Deploy Preview	https://deploy-preview-7231--docusaurus-2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

⚡️ Lighthouse report for the changes in this PR:

Lighthouse ran on https://deploy-preview-7231--docusaurus-2.netlify.app/

cc @jaredcbaum , looks relevant for what you did on Ionic doc here:

• https://github.com/ionic-team/ionic-docs/blob/main/docusaurus-theme-classic/src/index.js
• https://github.com/ionic-team/ionic-docs/blob/main/src/theme/NavbarItem/index.tsx

Looking forward to making all this easier in #7227

I attempted another workaround in the latest batch of updates to the ionic docs. This abstracts the validation logic to the Docusaurus config file. I was/am attempting to abstract a common theme that could also have custom schemas based on which site it was used on. I only got far enough for the navbar but theoretically it could be used for other schemas.

https://github.com/ionic-team/ionic-docs/blob/feat/plugin-abstraction/docusaurus.config.js#L211-L239
https://github.com/ionic-team/docusaurus-theme-classic-wrapper/blob/main/src/index.js#L28-L32

I think this is dancing around a bigger problem though, which is custom navbar parts. It seems as though this is in the works, but figured I'd post in case anyone was looking for an immediate workaround.

Also, just an idea but I think it would work well to have a generated list of the "native" NavbarItems from the original theme and anything else would be considered custom. In theory it could eliminate the need to prefix with "custom-"

Thanks @jaredcbaum, another workaround remains useful until we have proper support for this 👍

Also, just an idea but I think it would work well to have a generated list of the "native" NavbarItems from the original theme and anything else would be considered custom. In theory it could eliminate the need to prefix with "custom-"

We could as well allow unknown navbar item types in our navigation instead of constraining to custom-* pattern. But that also means we don't catch typos anymore, which we likely want to avoid for regular users that don't implement custom navbar items.

For now prefixing things with custom-* is likely good enough and would catch typos too.

Size Change: -580 B (0%)

Total Size: 802 kB

_{compressed-size-action}