fix(theme-classic): improve aria label of color mode toggle#6674
fix(theme-classic): improve aria label of color mode toggle#6674
Conversation
Josh-Cena
added
the
pr: polish
|
@JoshuaKGoldberg The GitHub review requesting panel is pretty awkward and I can't find your name. If you can take a look and see if your screenreader reads something better, it would be great. |
|
✔️ [V2] 🔨 Explore the source changes: 451f7c5 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/620afd2cde75380008bb86bb 😎 Browse the preview: https://deploy-preview-6674--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6674--docusaurus-2.netlify.app/ |
|
Size Change: +296 B (0%) Total Size: 780 kB
ℹ️ View Unchanged
|
| }) | ||
| : translate({ | ||
| message: 'light mode', | ||
| id: 'theme.colorToggle.ariaLabel,mode.light', |
There was a problem hiding this comment.
should this be . not ,?
There was a problem hiding this comment.
Oops, good catch!
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Yup, I'm not an expert but in general looks good to me, thank you!
5 participants
Motivation
Close #6665.
Have you read the Contributing Guidelines on pull requests?
Yes