fix(content-docs): read last update from inner git repositories#6592
Merged
Josh-Cena merged 1 commit intofacebook:mainfrom Feb 3, 2022
felipecrs:reapply-5048
Merged
fix(content-docs): read last update from inner git repositories#6592Josh-Cena merged 1 commit intofacebook:mainfrom felipecrs:reapply-5048
Josh-Cena merged 1 commit intofacebook:mainfrom
felipecrs:reapply-5048
Conversation
|
✔️ [V2] 🔨 Explore the source changes: 5612b60 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61fb5241e206bf0007da92c0 😎 Browse the preview: https://deploy-preview-6592--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6592--docusaurus-2.netlify.app/ |
Contributor
Author
|
One check cancelled? Should I do something? |
Josh-Cena
approved these changes
Feb 3, 2022
Collaborator
Josh-Cena
left a comment
There was a problem hiding this comment.
Thanks! It makes sense to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reapplies #5048, because it somehow got reverted during a refactoring (I believe).
To prevent it from happening again in future, I added a comment in the code.
This also:
Expand
-1into--max-count=1(long options are always preferred for better readability)Add
--to prevent file names who looks like git options to clashCheck if the file exists before issuing
gitand return a proper error messagegit logis known to return exit code 0 but no output in some cases, such as when using--and the file does not exist