fix(theme-classic): make React elements in pre render correctly#6177
Merged
fix(theme-classic): make React elements in pre render correctly#6177
Conversation
|
✔️ [V2] 🔨 Explore the source changes: cf373d1 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61c5d740a94c4b0009a9bd3b 😎 Browse the preview: https://deploy-preview-6177--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6177--docusaurus-2.netlify.app/ |
|
Size Change: +359 B (0%) Total Size: 662 kB
ℹ️ View Unchanged
|
Josh-Cena
added
the
status: awaiting review
Josh-Cena
removed
the
status: awaiting review
7 tasks
slorber
reviewed
Dec 27, 2021
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #6156. It seems the solution in #3749 was not good enough since it doesn't take React elements into account; this is further traced back to #1584 where Endi decided to unwrap the
prewhen the children is a React element. However that would not be the user's intention, because GitHub treats<pre>as code blocks:Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
https://deploy-preview-6177--docusaurus-2.netlify.app/tests/pages/code-block-tests