fix(v2): read last update from inner git repositories#5048
fix(v2): read last update from inner git repositories#5048slorber merged 1 commit intofacebook:masterfrom felipecrs:fix-last-update
Conversation
|
✔️ [V2] 🔨 Explore the source changes: 08f8e98 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60d37c8fba8573000804c2d2 😎 Browse the preview: https://deploy-preview-5048--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5048--docusaurus-2.netlify.app/ |
|
Thanks, that looks fine 👍 as long as it does not break current lastUpdate for simpler setups |
|
Hi @felipecrs Just wondering, is your site with multiple Git submodules opoen-source? I'd be interested to check it because we'd like to optimize those git log calls as part of e18e/ecosystem-issues#216 and your setup might be a good representative example to benchmark against |
|
Unfortunately it is not. It would otherwise be a good benchmark candidate indeed! (unless you want me to benchmark for you) |
Motivation
My use case:
With the current implementation, the
lastUpdatewon't return any data, as the files are unknown by Git when usingwebsiteas thecwd. But if we call git in their own folders, git will be able to properly read the metadata.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
I verified by replacing the content of
lastUpdate.jsin mynode_modulesfolder, which worked. But if needed, I can find a way to record a video. I just didn't record yet because in my tests there are private data from my company.The good news is that this change won't break any existing use case, it will just fix mine.
Related PRs
None