feat(v2): provide doc sidebar_label through sidebars.js#4500
feat(v2): provide doc sidebar_label through sidebars.js#4500slorber merged 14 commits intofacebook:masterfrom
Conversation
[pull] master from facebook:master
[pull] master from facebook:master
[pull] master from facebook:master
[pull] master from facebook:master
[pull] master from facebook:master
|
[V1] Deploy preview failure Built without sensitive environment variables with commit 3723ff0 |
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 3723ff0 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4500--docusaurus-2.netlify.app/ |
slorber
changed the title
slorber
left a comment
slorber
left a comment
There was a problem hiding this comment.
Thanks @besemuna , the feature is working great and as I expected.
To be complete we need:
- doc
- unit tests (particularly showing that
sidebarLabelis used in priority overitem.label) - dogfooding on Docusaurus site itself
I suggest you refactor the i18n docs to declare the sidebar label to use through the sidebars.js file (using this new feature) instead of using frontmatter sidebar_label: xyz.
slorber
left a comment
slorber
left a comment
There was a problem hiding this comment.
thanks
can you please remove the doc backport to older versions, apply my suggestion and add some tests?
website/versioned_docs/version-2.0.0-alpha.71/guides/docs/sidebar.md
Outdated
Show resolved
Hide resolved
website/versioned_docs/version-2.0.0-alpha.72/guides/docs/sidebar.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Sébastien Lorber <[email protected]>
|
Thanks, that looks great 👍 |
5 participants
Motivation
Attempt to fix #4314. These are the changes I've made
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)