Skip to content

Comments

feat(v2): debug pages + debug layout + ability to debug content#3229

Merged
slorber merged 6 commits intomasterfrom
slorber/improve-debug
Aug 7, 2020
Merged

feat(v2): debug pages + debug layout + ability to debug content#3229
slorber merged 6 commits intomasterfrom
slorber/improve-debug

Conversation

@slorber
Copy link
Collaborator

@slorber slorber commented Aug 6, 2020

Motivation

We need some basic infrastructure, because displaying all debug data on the same page is not very sustainable.

Also, it's painful to work on the docs plugin as the contentLoaded data is complex and not intuitive to handle.
This data only in memory and not easy to debug.
I've enhanced the code so that the debug plugin can display such contentLoaded data.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview + Dogfooding

Note, I've forced the debug plugin on Docusaurus v2 website, so it can be seen here:
https://deploy-preview-3229--docusaurus-2.netlify.app/build/__docusaurus/debug


cc @SamChou19815, going to merge this tomorrow, as I need to refactor a bit the docs plugin contentLoaded I'll need this :)

MLH can probably try to make each page more beautiful, this PR is mostly the initial infra

- add multiple debug pages + debug layout
- ability to debug plugin contentLoaded data
@slorber slorber requested a review from yangshun as a code owner August 6, 2020 18:44
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 6, 2020
@docusaurus-bot
Copy link
Contributor

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Aug 6, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants