fix(v2): always exit after successful build#2443
Merged
yangshun merged 3 commits intofacebook:masterfrom Mar 23, 2020
Merged
Conversation
Contributor
|
Deploy preview for docusaurus-2 ready! Built with commit f9fd76c |
mohrash92
changed the title
lex111
approved these changes
Mar 22, 2020
Contributor
lex111
left a comment
lex111
left a comment
There was a problem hiding this comment.
This comes from async operations (e.g. setInterval in custom React component). But in any case, the building must finishes successfully therefore LGTM.
This was referenced Apr 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When running
yarn build, a successful build does not always exit as highlighted in the following issue #2431. We can achieve this by exiting when the build has finished.Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
yarnandyarn buildbuild.jsofhookstatewith the one fromdocusaurus v2yard buildand the process exits instead of not exiting after build is successfulyarn build --out-dir build/nestedto ensure that the nested folder is generated and it works.(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)