Skip to content

Comments

docs(v2): search - algolia and custom#1734

Merged
endiliey merged 2 commits intomasterfrom
endiliey/search
Aug 2, 2019
Merged

docs(v2): search - algolia and custom#1734
endiliey merged 2 commits intomasterfrom
endiliey/search

Conversation

@endiliey
Copy link
Contributor

@endiliey endiliey commented Aug 1, 2019

Motivation

#1640

Search section

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

Netlify

@endiliey endiliey requested a review from yangshun as a code owner August 1, 2019 13:39
@endiliey endiliey requested a review from wgao19 August 1, 2019 13:39
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 1, 2019
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Aug 1, 2019

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Aug 1, 2019

Copy link
Contributor

@wgao19 wgao19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this! I have a few edits, reviewed by directly committing to your branch.

@wgao19 wgao19 mentioned this pull request Aug 2, 2019
20 tasks
@endiliey
Copy link
Contributor Author

endiliey commented Aug 2, 2019

thanks

@endiliey endiliey merged commit d6d113b into master Aug 2, 2019
@endiliey
Copy link
Contributor Author

endiliey commented Aug 2, 2019

will send more docs pr

@endiliey endiliey deleted the endiliey/search branch August 2, 2019 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants