Skip to content

Comments

docs(v2): deploy to netlify#1719

Merged
wgao19 merged 1 commit intomasterfrom
wgao19/docs-deploy-netlify
Jul 28, 2019
Merged

docs(v2): deploy to netlify#1719
wgao19 merged 1 commit intomasterfrom
wgao19/docs-deploy-netlify

Conversation

@wgao19
Copy link
Contributor

@wgao19 wgao19 commented Jul 28, 2019

Motivation

Addresses #1640, add docs for deployment to Netlify

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

NA

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@wgao19 wgao19 requested review from endiliey and yangshun as code owners July 28, 2019 05:22
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 28, 2019
@endiliey
Copy link
Contributor

endiliey commented Jul 28, 2019

@wgao19 wgao19 mentioned this pull request Jul 28, 2019
20 tasks
@docusaurus-bot
Copy link
Contributor

@wgao19
Copy link
Contributor Author

wgao19 commented Jul 28, 2019

I don't understand, how can a deploy preview fail for v1 site?

@endiliey
Copy link
Contributor

sometimes netlify isnt perfect :)

@wgao19 wgao19 merged commit 4344b1a into master Jul 28, 2019
@wgao19 wgao19 deleted the wgao19/docs-deploy-netlify branch July 28, 2019 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants