Conversation
20 tasks
Contributor
|
Deploy preview for docusaurus-2 ready! Built with commit 3c29c45 |
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit 3c29c45 |
endiliey
suggested changes
Jul 25, 2019
Contributor
endiliey
left a comment
endiliey
left a comment
There was a problem hiding this comment.
small nits otherwise lgtm we can tweak more in the future. i plan to write some docs maybe this week
website/docs/contributing.md
Outdated
|
|
||
| - Start using Docusaurus 2! Go through the [Getting Started](installation.md) guides. Does everything work as expected? If not, we're always looking for improvements. Let us know by [opening an issue](#reporting-new-issues). | ||
| - Look through the [v2.0 issues](https://github.com/facebook/docusaurus/labels/2.x). If you find an issue you would like to fix, [open a pull request](#your-first-pull-request). Issues tagged as [_Good first issue_](https://github.com/facebook/docusaurus/labels/Good%20first%20issue) are a good place to get started. | ||
| - Help us making the [docs](/docs/introduction) better. File an issue if you find anything that is confusing or can be improved. We also have [an umbrella issue for v2 docs](https://github.com/facebook/docusaurus/issues/1640) where we are planning and working on all v2 docs. You may adopt a doc piece there to work on. |
Contributor
There was a problem hiding this comment.
dont use hardcoded url /docs/introduction
use introduction.md
Contributor
Author
There was a problem hiding this comment.
actually, decided to remove the link because the reader should already be in the doc.
endiliey
approved these changes
Jul 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Addressing #1640, add docs for contributing for v2.
Copied over CONTRIBUTING.md from root and reorganized for v2.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
NA
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)
#1640