Conversation
wgao19
force-pushed
the
wgao19/docs-analytics
branch
from
f14354f to
8fa7d3a
Compare
|
Hey @yangshun got a question: We provide Please let me know, then I'll make changes in this PR to reflect the idea. |
|
Deploy preview for docusaurus-2 ready! Built with commit f14354f |
|
Deploy preview for docusaurus-preview ready! Built with commit f14354f |
|
Deploy preview for docusaurus-2 ready! Built with commit 77a3757 |
|
Deploy preview for docusaurus-preview ready! Built with commit 77a3757 |
wgao19
force-pushed
the
wgao19/docs-analytics
branch
from
8fa7d3a to
6c47646
Compare
| [ | ||
| '@docusaurus/plugin-google-gtag', | ||
| { | ||
| trackingID: 'UA-142857148-5', |
There was a problem hiding this comment.
its done through themeconfig right ?
There was a problem hiding this comment.
Recommended that in the "analytics" section and purposely moved how to manually set it up via plugins to this "advanced guide: plugins" section.
There was a problem hiding this comment.
yep. what i mean is that
// docusaurus.config.js
module.exports = {
plugins: [
[
'@docusaurus/plugin-google-analytics',
{
trackingID: 'UA-142857148-5',
},
],
],
};is essentially the same as
```js
// docusaurus.config.js
module.exports = {
plugins: ['@docusaurus/plugin-google-analytics',]
};
because tracking id needs to be done in themeConfig instead
cc the plugin author @yangshun for clarify
|
By the way, @endiliey it seems that the link from analytics to sections in the advanced plugins page is once again not landing on the headings correctly... |
4 participants
Motivation
Addressing #1640, add docs for adding analytics
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)