Skip to content

Comments

docs(v2): subcategories#1670

Merged
yangshun merged 2 commits intomasterfrom
wgao19/docs-sidebar-subcategories
Jul 18, 2019
Merged

docs(v2): subcategories#1670
yangshun merged 2 commits intomasterfrom
wgao19/docs-sidebar-subcategories

Conversation

@wgao19
Copy link
Contributor

@wgao19 wgao19 commented Jul 18, 2019

Motivation

Addressing #1640, add doc section on subcategories

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@wgao19 wgao19 requested review from endiliey and yangshun as code owners July 18, 2019 00:46
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 18, 2019
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jul 18, 2019

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jul 18, 2019

@wgao19 wgao19 mentioned this pull request Jul 18, 2019
20 tasks
Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

@yangshun yangshun merged commit 40cf5dc into master Jul 18, 2019
@endiliey endiliey deleted the wgao19/docs-sidebar-subcategories branch July 21, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants