Conversation
|
Deploy preview for docusaurus-2 ready! Built with commit 2411afa |
yangshun
left a comment
yangshun
left a comment
There was a problem hiding this comment.
Can we do a @docusaurus/cli package instead and move the commands there? Idk if our architecture permits that at the moment but it'll be good if we can do that.
I actually thought of that too but after some thought i realize that this approach has a very superior advantage: super fast and separated concern. This is also an approach used by CRA. The thing with having CLI (which i believe can be installed globally like gatsby-cli) and being separated from core is that it can sometimes lead to subtle bugs in behavior and functionality if the version of the globally installed executable does not match the version of core. Another thing is that if we move the init to docusaurus/cli, it means that the init templates wlll live inside that package. More installation time for all user that doesnt want to init |
yangshun
left a comment
yangshun
left a comment
There was a problem hiding this comment.
Sure, we should remember to update the docs before releasing a new version.
|
just the src/pages and src/themes docs stuff and we should be good to go for alpha 20 oh and pls help to add to our tasklist on the CLI in case i forget. gotta sleep |
4 participants
Motivation
Close #1601
The right way to test this out as npm package is to actually release alpha.20 and try it out.
Others
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
At root, after installing, compile typescript and mimic running the init command
https://asciinema.org/a/vcInXTcBCChXyIexXPmIAx4HI