Skip to content

Comments

WiP docs(v2): Docusaurus 2 docs#1578

Closed
wgao19 wants to merge 2 commits intomasterfrom
wgao19/wip-docs
Closed

WiP docs(v2): Docusaurus 2 docs#1578
wgao19 wants to merge 2 commits intomasterfrom
wgao19/wip-docs

Conversation

@wgao19
Copy link
Contributor

@wgao19 wgao19 commented Jun 6, 2019

Motivation

Opening this PR for review and discussion on work in progress docs. I will brief my thoughts in follow up comments. And I'll PR complete pieces incrementally.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

NA

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@wgao19 wgao19 requested review from endiliey and yangshun as code owners June 6, 2019 18:23
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jun 6, 2019

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jun 6, 2019

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 6, 2019
Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like the change but not so much on removing the comparisons + features as points are more catchy & concise. wdyt @yangshun

Keeping a well-maintained `docusaurus.config.js` helps you, your collaborators, and your open source contributors be able to focus on docs while having certain fields easy to customize.

For reference to each of the configurable fields, you may refer to the API reference of [docusaurus.config.js](/docs/docusaurus.config.js).
For reference to each of the configurable fields, you may refer to the API reference of [docusaurus.config.js](docusaurus.config.js).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.md

- [Theme configurations, plugins, and presets](#theme-plugins-and-presets-configurations)
- [Custom configurations](#custom-configurations)

For more details on the API, check out [the API Reference on `docusaurus.config.js`](docusaurus.config.js)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.md

<img src="https://docusaurus.io/img/slash-introducing.svg" alt="Docusaurus"/>

Docusaurus 1 used to be a documentation site generator. In Docusaurus 2, we rebuilt it from the ground up, allowing for more customizability but preserved the best parts of Docusaurus 1 - easy to get started. Docusaurus 2 is a **performant static site generator** can be used to create most content-driven websites (e.g. Documentation, Blogs, Product Landing and Marketing Pages, etc) extremely fast. Out of the box, we have support for documentation-style and blogging websites.
Docusaurus 1 used to be a pure documentation site generator. In Docusaurus 2, we rebuilt it from the ground up, allowing for more customizability but preserved the best parts of Docusaurus 1 - easy to get started, versioned docs, and i18n.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets omit this part first, just “easy to get started”. versioning and i18n is not yet done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also i like the previous text of can be created to build blog, docs out of the box

- ✂️ **Easy** - Hot reloading out-of-the-box, automatic route-based code and data splitting! Create new routes by creating new Markdown or JSX files
- 💥 **Single-page Application** - Client-side navigations and easily add dynamic interactivity to your website (Client-side Rendering)
- 🎯 **SEO Friendly** - `index.html` files are statically generated for every possible path (Static Rendering)
- 😌 **Painless** - Painless project setup. First class support for documentation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the comparison removed ? also i think the feature as bullet points are more appealing too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think the comparison should stay. People won't need to spend the effort to figure out what the differences are.

I'm neutral about the format of features.

Copy link
Contributor

@endiliey endiliey Jun 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the comparison docs and features being explained like this, the docs will be too long. i hope the introduction docs itself is not too long.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I will bring back the comparisons. I am not against it just that I prefer not to compare in a way that says how others don't fit. So I'll rephrase part of those.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup at least keep the comparisons.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer not to compare in a way that says how others don't fit.

Our intention is to state facts and what each tool is good for. The intention is not to criticize. As a user I'll appreciate fair and accurate comparisons that saves me time from doing it myself.

I'll rephrase part of those

Yes please 😄

@wgao19
Copy link
Contributor Author

wgao19 commented Jun 8, 2019 via email

@wgao19 wgao19 force-pushed the wgao19/wip-docs branch from 6c34916 to ff6617a Compare June 13, 2019 02:43
@wgao19
Copy link
Contributor Author

wgao19 commented Jun 13, 2019

Closing this in favor of PRs for individual pieces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants