Skip to content

Comments

fix(translations): improve Arabic theme translations#11484

Merged
slorber merged 5 commits intofacebook:mainfrom
maysara-elshewehy:dev
Oct 17, 2025
Merged

fix(translations): improve Arabic theme translations#11484
slorber merged 5 commits intofacebook:mainfrom
maysara-elshewehy:dev

Conversation

@maysara-elshewehy
Copy link
Contributor

@maysara-elshewehy maysara-elshewehy commented Oct 15, 2025

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

The Arabic translation wasn't good enough, there were a lot of spelling mistakes that were annoying to readers, so I tried to make it better, nothing more.

@meta-cla
Copy link

meta-cla bot commented Oct 15, 2025

Hi @maysara-elshewehy!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@netlify
Copy link

netlify bot commented Oct 15, 2025

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 5e95a12
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/68f1975ca0b0860008f89e28
😎 Deploy Preview https://deploy-preview-11484--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@meta-cla
Copy link

meta-cla bot commented Oct 15, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed Signed Facebook CLA label Oct 15, 2025
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really know if this is an improvement

But are the extra spaces in | really needed?

@slorber slorber changed the title Fix typos in Arabic translation fix(translations): improve Arabic theme translations Oct 16, 2025
@slorber slorber added the pr: translations This PR is related to Docusaurs core, theme or website translations label Oct 16, 2025
@slorber slorber merged commit d9d2904 into facebook:main Oct 17, 2025
41 of 42 checks passed
@maysara-elshewehy maysara-elshewehy deleted the dev branch October 17, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: translations This PR is related to Docusaurs core, theme or website translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants