fix(theme-search-algolia): Fix Algolia AskAI validation logic#11468
Merged
fix(theme-search-algolia): Fix Algolia AskAI validation logic#11468
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: +317 B (0%) Total Size: 11.8 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +307 B (0%) Total Size: 12.2 MB ℹ️ View Unchanged
|
slorber
commented
Oct 10, 2025
Collaborator
Author
slorber
left a comment
slorber
left a comment
There was a problem hiding this comment.
Can you please review @dylantientcheu @NatanTechofNY and let me know if that looks good?
Comment on lines
+71
to
+74
| // Optional Ask AI configuration | ||
| indexName: Joi.string().optional(), | ||
| apiKey: Joi.string().optional(), | ||
| appId: Joi.string().optional(), |
Collaborator
Author
There was a problem hiding this comment.
these attributes are optional and can use the root algolia config as fallback right?
Contributor
There was a problem hiding this comment.
yes, they are optional & they look good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current validation did not accept the following configs, which should both be fine IMHO:
I noticed this when trying to enable our markdown-based index that the DocSearch team prepared for us. This PR also adds the new index to our website.
Test Plan
CI + deploy preview
Test links
https://deploy-preview-11468--docusaurus-2.netlify.app/