feat(eslint): add prefer-ideal-image rule#11416
Closed
IsmailBinMujeeb wants to merge 4 commits intofacebook:mainfrom
Closed
feat(eslint): add prefer-ideal-image rule#11416IsmailBinMujeeb wants to merge 4 commits intofacebook:mainfrom
IsmailBinMujeeb wants to merge 4 commits intofacebook:mainfrom
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
slorber
changed the title
slorber
changed the title
slorber
requested changes
Sep 19, 2025
Collaborator
slorber
left a comment
slorber
left a comment
There was a problem hiding this comment.
We already have a PR for this feature: #8826
I'd be fine if you continue the work started by @Devansu-Yadav, but we need to consider edge cases, and we don't want extra useless warnings where we previously didn't have.
For example, this JSX that we use on our own website is perfectly fine and shouldn't warn by default:
<img
alt={name}
className="avatar__photo"
src={`https://unavatar.io/x/${handle}?fallback=https://github.com/${githubUsername}.png`}
width="48"
height="48"
loading="lazy"
/>
Collaborator
|
This updated PR doesn't handle the review I gave in #8826 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
proposal mentioned in #6472, This newly added
prefer-ideal-imageenforces the use of@theme/IdealImagecomponent instead of<img>tag for images.Test Plan
Added a test
prefer-ideal-imagewith:<Image src={thumbnail}/>and<Image src='path/to/image'/>.<img sec={thumbnail} />and<img sec='path/to/image' />.Test links
Rule docs page
Updated Rules Table
Related issues/PRs
#6472