Skip to content

Comments

fix(theme-common): Export FooterColumnItem type#11280

Merged
slorber merged 1 commit intofacebook:mainfrom
stubinubin:patch-1
Jun 19, 2025
Merged

fix(theme-common): Export FooterColumnItem type#11280
slorber merged 1 commit intofacebook:mainfrom
stubinubin:patch-1

Conversation

@stubinubin
Copy link
Contributor

@stubinubin stubinubin commented Jun 19, 2025

Export FooterColumnItem type from utils/useThemeConfig.

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

I'm trying to create presets for footer section where i have multiple docusaurus.config.ts files for each deployment environment. I wanted to add FooterColumnItem type to each footer column preset for type safety and noticed that FooterLinkItem is exported but column item was not.

Test Plan

I've not written any tests for this, advice welcome if it's needed.

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

I don't believe this is related to any issues or pre/existing PR's.

@stubinubin
Export FooterColumnItem type
dd551f6 
Export FooterColumnItem type from utils/useThemeConfig.
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 19, 2025

Hi @stubinubin!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@netlify
Copy link

netlify bot commented Jun 19, 2025

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit dd551f6
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/6853ce72ba54f30008bc9a4a
😎 Deploy Preview https://deploy-preview-11280--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Jun 19, 2025

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🔴 39 🟢 98 🟢 100 🟢 100 Report
/docs/installation 🟠 55 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 70 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 56 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 56 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 78 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 69 🟢 100 🟢 100 🟠 86 Report

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 19, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 19, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@stubinubin
Copy link
Contributor Author

stubinubin commented Jun 19, 2025

As a work around for now I'm having to copy FooterColumnItem type from useThemeConfig.ts

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jun 19, 2025
@slorber slorber changed the title Export FooterColumnItem type fix(theme): Export FooterColumnItem type Jun 19, 2025
@slorber slorber changed the title fix(theme): Export FooterColumnItem type fix(theme-common): Export FooterColumnItem type Jun 19, 2025
slorber
slorber approved these changes Jun 19, 2025
View reviewed changes
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Agree to export it for consistency, considering this as a bug

@slorber slorber merged commit 068d4c6 into facebook:main Jun 19, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slorber slorber slorber approved these changes

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees

No one assigned

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stubinubin @facebook-github-bot @slorber