chore(ci): add yarn-v1-windows e2e job#11231
Merged
Conversation
slorber
added
the
pr: ignore
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
This was referenced Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We currently don't run e2e tests on Windows
(the existing windows jobs run our website
yarn build:website:fast, not the initial template.I'm also adding an
actions/upload-artifactstep so that we can more easily inspect the build output. I don't have a Windows laptop so it can help troubleshoot windows-related problems (like this one)Test Plan
CI
Windows notes:
For history, running the yarn scrit
yarn test:build:websitewouldn't work on Windows. The script wouldn't execute, and surprisingly wouldn't fail the GitHub action for unknown reason.If we ever need to run a script on Windows, using
bashworked better:But now we have another problem:
Unfortunately, there's no pre-built "verdaccio" docker image on Windows.
So I didn't use a real npm repository, and simply generated the test site inside the yarn workspace. Maybe we should migrate all our CI tests to that setup because it would be faster than using Verdaccio. I guess keeping only one job on Verdaccio could be useful though, since it's closer to what real users will run.