fix(core): fix DOCUSAURUS_CURRENT_LOCALE = 'undefined'#10611
Merged
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: +338 B (0%) Total Size: 11.1 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +328 B (0%) Total Size: 11.6 MB ℹ️ View Unchanged
|
slorber
added
the
Argos
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If you do
process.env.XYZ = undefinedin Node.js, the env variable will be a string'undefined', and not the expectedundefined, which is confusing.This code has always been a bit hacky and not considered as part of the public API surface, so I'm removing it.
On the first load, the config file will always be loaded with
DOCUSAURUS_CURRENT_LOCALE = undefinednow. It's only later once we start iterating over locales that we'll set theDOCUSAURUS_CURRENT_LOCALEvariable.Test Plan
CI + local