Skip to content

Comments

feat(theme): OS-default color mode#10474

Closed
OzakIOne wants to merge 2 commits intomainfrom
ozaki/systemMode
Closed

feat(theme): OS-default color mode#10474
OzakIOne wants to merge 2 commits intomainfrom
ozaki/systemMode

Conversation

@OzakIOne
Copy link
Contributor

@OzakIOne OzakIOne commented Sep 3, 2024

Motivation

Up to date #8474 by @nasso I just couldn't get to merge main easily 😅

Fix #8074

  • run yarn workspace @docusaurus/theme-translations update

Test Plan

Deploy, CI, ???

Test links

Deploy preview: https://deploy-preview-10474--docusaurus-2.netlify.app/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 3, 2024
@netlify
Copy link

netlify bot commented Sep 3, 2024

[V2]

Name Link
🔨 Latest commit 6f5c7e1
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66d718a699300300084dc000
😎 Deploy Preview https://deploy-preview-10474--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Sep 3, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 59 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 52 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 73 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 63 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 48 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 63 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 73 🟢 100 🟢 100 🟠 86 Report

@github-actions
Copy link

github-actions bot commented Sep 3, 2024

Size Change: +50.9 kB (+0.44%)

Total Size: 11.6 MB

Filename Size Change
website/.docusaurus/docusaurus.config.mjs 27.8 kB -40 B (-0.14%)
website/build/assets/css/styles.********.css 113 kB +208 B (+0.18%)
website/build/assets/js/main.********.js 668 kB +1.92 kB (+0.29%)
website/build/blog.html 61.7 kB +378 B (+0.62%)
website/build/blog/2017/12/14/introducing-docusaurus.html 75.1 kB +364 B (+0.49%)
website/build/blog/2018/04/30/How-I-Converted-Profilo-To-Docusaurus.html 47.7 kB +377 B (+0.8%)
website/build/blog/2018/09/11/Towards-Docusaurus-2.html 52.1 kB +377 B (+0.73%)
website/build/blog/2018/12/14/Happy-First-Birthday-Slash.html 30.8 kB +364 B (+1.2%)
website/build/blog/2019/12/30/docusaurus-2019-recap.html 39.9 kB +364 B (+0.92%)
website/build/blog/2020/01/07/tribute-to-endi.html 34.4 kB +364 B (+1.07%)
website/build/blog/2021/01/19/docusaurus-2020-recap.html 49.3 kB +364 B (+0.74%)
website/build/blog/2021/03/09/releasing-docusaurus-i18n.html 45.5 kB +364 B (+0.81%)
website/build/blog/2021/05/12/announcing-docusaurus-two-beta.html 47.9 kB +364 B (+0.77%)
website/build/blog/2021/11/21/algolia-docsearch-migration.html 53.3 kB +377 B (+0.71%)
website/build/blog/2022/01/24/docusaurus-2021-recap.html 44.9 kB +364 B (+0.82%)
website/build/blog/2022/08/01/announcing-docusaurus-2.0.html 140 kB +688 B (+0.49%)
website/build/blog/2022/09/01/docusaurus-2.1.html 51.3 kB +364 B (+0.72%)
website/build/blog/archive.html 25.1 kB +378 B (+1.53%)
website/build/blog/authors.html 46.9 kB +378 B (+0.81%)
website/build/blog/authors/j-marcey.html 65.4 kB +378 B (+0.58%)
website/build/blog/authors/josh-cena.html 43.4 kB +378 B (+0.88%)
website/build/blog/authors/lex-111.html 50.6 kB +378 B (+0.75%)
website/build/blog/authors/slorber.html 61.9 kB +378 B (+0.61%)
website/build/blog/authors/slorber/authors/2.html 65.8 kB +378 B (+0.58%)
website/build/blog/authors/slorber/authors/3.html 78 kB +378 B (+0.49%)
website/build/blog/authors/slorber/authors/4.html 45.1 kB +378 B (+0.84%)
website/build/blog/authors/yangshun.html 58.1 kB +378 B (+0.65%)
website/build/blog/authors/zpao.html 43.9 kB +378 B (+0.87%)
website/build/blog/page/2.html 66.4 kB +378 B (+0.57%)
website/build/blog/page/3.html 72.1 kB +378 B (+0.53%)
website/build/blog/page/4.html 64.6 kB +378 B (+0.59%)
website/build/blog/page/5.html 42.2 kB +378 B (+0.9%)
website/build/blog/preparing-your-site-for-docusaurus-v3.html 139 kB +364 B (+0.26%)
website/build/blog/releases/2.2.html 50 kB +365 B (+0.74%)
website/build/blog/releases/2.3.html 61.2 kB +365 B (+0.6%)
website/build/blog/releases/2.4.html 65.7 kB +365 B (+0.56%)
website/build/blog/releases/3.0.html 112 kB +377 B (+0.34%)
website/build/blog/releases/3.1.html 52.4 kB +366 B (+0.7%)
website/build/blog/releases/3.2.html 49.2 kB +365 B (+0.75%)
website/build/blog/releases/3.3.html 55.9 kB +365 B (+0.66%)
website/build/blog/releases/3.4.html 56.2 kB +372 B (+0.67%)
website/build/blog/releases/3.5.html 58.4 kB +375 B (+0.65%)
website/build/blog/tags.html 28.9 kB +378 B (+1.32%)
website/build/blog/upgrading-frontend-dependencies-with-confidence-using-visual-regression-testing.html 128 kB +365 B (+0.28%)
website/build/docs.html 49.8 kB +373 B (+0.76%)
website/build/docs/advanced.html 31.5 kB +365 B (+1.17%)
website/build/docs/advanced/architecture.html 31 kB +369 B (+1.2%)
website/build/docs/advanced/client.html 76.4 kB +365 B (+0.48%)
website/build/docs/advanced/plugins.html 59 kB +365 B (+0.62%)
website/build/docs/advanced/routing.html 74.3 kB +375 B (+0.51%)
website/build/docs/advanced/ssg.html 81.8 kB +365 B (+0.45%)
website/build/docs/api/docusaurus-config.html 203 kB +365 B (+0.18%)
website/build/docs/api/misc/@docusaurus/eslint-plugin.html 48.7 kB +369 B (+0.76%)
website/build/docs/api/misc/@docusaurus/eslint-plugin/no-html-links.html 38.5 kB +365 B (+0.96%)
website/build/docs/api/misc/@docusaurus/eslint-plugin/no-untranslated-text.html 37.3 kB +365 B (+0.99%)
website/build/docs/api/misc/@docusaurus/eslint-plugin/prefer-docusaurus-heading.html 38.7 kB +369 B (+0.96%)
website/build/docs/api/misc/@docusaurus/eslint-plugin/string-literal-i18n-messages.html 42.3 kB +365 B (+0.87%)
website/build/docs/api/misc/@docusaurus/logger.html 40.2 kB +365 B (+0.92%)
website/build/docs/api/misc/create-docusaurus.html 35.2 kB +365 B (+1.05%)
website/build/docs/api/plugin-methods.html 67.8 kB +369 B (+0.55%)
website/build/docs/api/plugin-methods/extend-infrastructure.html 63.4 kB +369 B (+0.59%)
website/build/docs/api/plugin-methods/i18n-lifecycles.html 61 kB +369 B (+0.61%)
website/build/docs/api/plugin-methods/lifecycle-apis.html 171 kB +365 B (+0.21%)
website/build/docs/api/plugin-methods/static-methods.html 46.9 kB +369 B (+0.79%)
website/build/docs/api/plugins.html 32 kB +365 B (+1.15%)
website/build/docs/api/plugins/@docusaurus/plugin-client-redirects.html 62.9 kB +378 B (+0.6%)
website/build/docs/api/plugins/@docusaurus/plugin-content-blog.html 198 kB +378 B (+0.19%)
website/build/docs/api/plugins/@docusaurus/plugin-content-docs.html 203 kB +374 B (+0.18%)
website/build/docs/api/plugins/@docusaurus/plugin-content-pages.html 78.4 kB +366 B (+0.47%)
website/build/docs/api/plugins/@docusaurus/plugin-debug.html 50.9 kB +365 B (+0.72%)
website/build/docs/api/plugins/@docusaurus/plugin-google-analytics.html 51.9 kB +365 B (+0.71%)
website/build/docs/api/plugins/@docusaurus/plugin-google-gtag.html 51.4 kB +361 B (+0.71%)
website/build/docs/api/plugins/@docusaurus/plugin-google-tag-manager.html 50.2 kB +365 B (+0.73%)
website/build/docs/api/plugins/@docusaurus/plugin-ideal-image.html 51.5 kB +369 B (+0.72%)
website/build/docs/api/plugins/@docusaurus/plugin-pwa.html 122 kB +369 B (+0.3%)
website/build/docs/api/plugins/@docusaurus/plugin-sitemap.html 68.9 kB +371 B (+0.54%)
website/build/docs/api/plugins/@docusaurus/plugin-vercel-analytics.html 42.6 kB +377 B (+0.89%)
website/build/docs/api/themes.html 30.8 kB +365 B (+1.2%)
website/build/docs/api/themes/@docusaurus/theme-classic.html 46.8 kB +369 B (+0.8%)
website/build/docs/api/themes/@docusaurus/theme-live-codeblock.html 39 kB +369 B (+0.95%)
website/build/docs/api/themes/@docusaurus/theme-mermaid.html 37.9 kB +369 B (+0.98%)
website/build/docs/api/themes/@docusaurus/theme-search-algolia.html 35.1 kB +365 B (+1.05%)
website/build/docs/api/themes/configuration.html 257 kB +372 B (+0.15%)
website/build/docs/blog.html 219 kB +371 B (+0.17%)
website/build/docs/browser-support.html 51.4 kB +365 B (+0.72%)
website/build/docs/category/getting-started.html 28.6 kB +378 B (+1.34%)
website/build/docs/category/guides.html 36.8 kB +378 B (+1.04%)
website/build/docs/cli.html 64.2 kB +366 B (+0.57%)
website/build/docs/configuration.html 98.9 kB +369 B (+0.37%)
website/build/docs/create-doc.html 65.7 kB +377 B (+0.58%)
website/build/docs/creating-pages.html 59.5 kB +366 B (+0.62%)
website/build/docs/deployment.html 212 kB +374 B (+0.18%)
website/build/docs/docs-introduction.html 54 kB +365 B (+0.68%)
website/build/docs/docs-multi-instance.html 79.1 kB +369 B (+0.47%)
website/build/docs/docusaurus-core.html 246 kB +365 B (+0.15%)
website/build/docs/guides/whats-next.html 33.2 kB +365 B (+1.11%)
website/build/docs/i18n/crowdin.html 151 kB +377 B (+0.25%)
website/build/docs/i18n/git.html 83 kB +369 B (+0.45%)
website/build/docs/i18n/introduction.html 51.1 kB +365 B (+0.72%)
website/build/docs/i18n/tutorial.html 171 kB +378 B (+0.22%)
website/build/docs/installation.html 73.4 kB +377 B (+0.52%)
website/build/docs/markdown-features.html 83.6 kB +366 B (+0.44%)
website/build/docs/markdown-features/admonitions.html 119 kB +369 B (+0.31%)
website/build/docs/markdown-features/assets.html 93.9 kB +367 B (+0.39%)
website/build/docs/markdown-features/code-blocks.html 245 kB +369 B (+0.15%)
website/build/docs/markdown-features/diagrams.html 56.4 kB +379 B (+0.68%)
website/build/docs/markdown-features/head-metadata.html 53.2 kB +365 B (+0.69%)
website/build/docs/markdown-features/links.html 43.4 kB +365 B (+0.85%)
website/build/docs/markdown-features/math-equations.html 95.8 kB +376 B (+0.39%)
website/build/docs/markdown-features/plugins.html 101 kB +373 B (+0.37%)
website/build/docs/markdown-features/react.html 144 kB +365 B (+0.25%)
website/build/docs/markdown-features/tabs.html 149 kB +365 B (+0.25%)
website/build/docs/markdown-features/toc.html 89.1 kB +369 B (+0.42%)
website/build/docs/migration.html 43.4 kB +364 B (+0.85%)
website/build/docs/migration/v2.html 41.6 kB +365 B (+0.88%)
website/build/docs/migration/v2/automated.html 43 kB +365 B (+0.86%)
website/build/docs/migration/v2/manual.html 207 kB +365 B (+0.18%)
website/build/docs/migration/v2/translated-sites.html 53.2 kB +365 B (+0.69%)
website/build/docs/migration/v2/versioned-sites.html 67.6 kB +365 B (+0.54%)
website/build/docs/migration/v3.html 218 kB +365 B (+0.17%)
website/build/docs/playground.html 32.9 kB +365 B (+1.12%)
website/build/docs/search.html 121 kB +366 B (+0.3%)
website/build/docs/seo.html 93.3 kB +378 B (+0.41%)
website/build/docs/sidebar.html 136 kB +369 B (+0.27%)
website/build/docs/sidebar/autogenerated.html 157 kB +380 B (+0.24%)
website/build/docs/sidebar/items.html 188 kB +365 B (+0.19%)
website/build/docs/sidebar/multiple-sidebars.html 67.5 kB +369 B (+0.55%)
website/build/docs/static-assets.html 56.6 kB +369 B (+0.66%)
website/build/docs/styling-layout.html 141 kB +367 B (+0.26%)
website/build/docs/swizzling.html 121 kB +379 B (+0.31%)
website/build/docs/typescript-support.html 65.7 kB +365 B (+0.56%)
website/build/docs/using-plugins.html 116 kB +378 B (+0.33%)
website/build/docs/versioning.html 87.5 kB +378 B (+0.43%)
website/build/index.html 38.2 kB +378 B (+1%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/codeTranslations.json 2 B
website/.docusaurus/globalData.json 30.2 kB
website/.docusaurus/i18n.json 930 B
website/.docusaurus/registry.js 155 kB
website/.docusaurus/routes.js 74.3 kB
website/.docusaurus/routesChunkNames.json 81.7 kB
website/.docusaurus/site-metadata.json 2.17 kB
website/build/docs/introduction/index.html 280 B
website/build/docs/resources/index.html 325 B
website/build/docs/support/index.html 319 B
website/build/docs/team/index.html 310 B

compressed-size-action

@Josh-Cena Josh-Cena changed the title feat(theme): add system mode feat(theme): OS-default color mode Sep 6, 2024
@slorber
Copy link
Collaborator

slorber commented Mar 13, 2025

Thanks for the PR.

I'll close this in favor of #10987, but will credit you as a co-author.

@slorber slorber closed this Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reset to OS theme / colorMode should possible

3 participants